Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages 404 until browser is hard-refreshed #5046

Open
susodapop opened this issue Jul 15, 2020 · 1 comment
Open

Pages 404 until browser is hard-refreshed #5046

susodapop opened this issue Jul 15, 2020 · 1 comment

Comments

@susodapop
Copy link
Contributor

Issue Summary

This bug bites me a lot on SaaS Redash. I can finally reproduce it! It happens when I click a link to a page in Redash (like a bookmark to a query or dashboard). Instead of loading the page normally I see the "It seems like the page you're looking for cannot be found." message. But the page will still work after I do a hard page refresh (F5 or ⌘⇧R).

I shouldn't need to hard refresh the page for this to work.

Steps to Reproduce

I reproduced on the preview instance here. You can also reproduce using the public shared dashboard link here.

  1. Write a simple query without parameters: SELECT 1 foo
  2. Publish it and copy its CSV download link
  3. Visit the CSV download link from a browser with an active Redash session

Alternatively you can reproduce like I did:

  1. same as above
  2. same as above
  3. Make a dashboard with a textbox widget and link to the CSV results download
  4. Click the CSV link

Technical details:

  • Redash Version: v9 Beta
  • Browser/OS: FF, Edge, Safari
  • How did you install Redash: SaaS
@gabrieldutra
Copy link
Member

gabrieldutra commented Jul 15, 2020

@susodapop I'm not sure about this happening when you click on a bookmark to a query or a dashboard (it can be a different bug though). This one seems related to be a Router problem, i.e.: it is identifying the /api/[...]/results link as an internal link and trying to handle it as an internal Route on the frontend (without reloading the page). Since this route doesn't exist (it is an api route, so it's not on frontend), it returns 404.

@kravets-levko maybe we should check if the route exists in the Router before sending it to be handled with it? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants