refactor: remove unused findChangelogInsertionPoint function and its tests

Author: vaind

danger/dangerfile-utils.js

@@ -54,91 +54,6 @@ function getFlavorConfig(prFlavor) {
   };
 }
 
-/// Find the appropriate line to insert a changelog entry
-function findChangelogInsertionPoint(lines, sectionName) {
-  let unreleasedIndex = -1;
-  let sectionIndex = -1;
-  let insertionLine = -1;
-  let isNewSection = false;
-
-  // Find the "## Unreleased" section
-  for (let i = 0; i < lines.length; i++) {
-    if (lines[i].match(/^##\s+Unreleased/i)) {
-      unreleasedIndex = i;
-      break;
-    }
-  }
-
-  if (unreleasedIndex === -1) {
-    // No "Unreleased" section found
-    return { success: false };
-  }
-
-  // Look for the target section under "Unreleased"
-  for (let i = unreleasedIndex + 1; i < lines.length; i++) {
-    // Stop if we hit another ## section (next release)
-    if (lines[i].match(/^##\s+/)) {
-      break;
-    }
-
-    // Check if this is our target section
-    if (lines[i].match(new RegExp(`^###\\s+${sectionName}`, 'i'))) {
-      sectionIndex = i;
-      break;
-    }
-  }
-
-  if (sectionIndex !== -1) {
-    // Found the section, find where to insert within it
-    for (let i = sectionIndex + 1; i < lines.length; i++) {
-      // Stop if we hit another section or end
-      if (lines[i].match(/^##[#]?\s+/)) {
-        break;
-      }
-
-      // Find the first non-empty line after the section header
-      if (lines[i].trim() !== '') {
-        // Insert before this line if it's not already a bullet point
-        insertionLine = lines[i].match(/^-\s+/) ? i + 1 : i;
-        break;
-      }
-    }
-
-    // If we didn't find a good spot, insert right after the section header
-    if (insertionLine === -1) {
-      insertionLine = sectionIndex + 2; // +1 for the section, +1 for empty line
-    }
-  } else {
-    // Section doesn't exist, we need to create it
-    isNewSection = true;
-
-    // Find where to insert the new section
-    // Look for the next section after Unreleased or find a good spot
-    for (let i = unreleasedIndex + 1; i < lines.length; i++) {
-      if (lines[i].match(/^##\s+/)) {
-        // Insert before the next release section
-        insertionLine = i - 1;
-        break;
-      } else if (lines[i].match(/^###\s+/)) {
-        // Insert before the first existing section
-        insertionLine = i;
-        break;
-      }
-    }
-
-    // If no good spot found, insert after a reasonable gap from Unreleased
-    if (insertionLine === -1) {
-      insertionLine = unreleasedIndex + 2;
-    }
-  }
-
-  return {
-    success: true,
-    lineNumber: insertionLine + 1, // Convert to 1-based line numbering
-    isNewSection: isNewSection,
-    sectionHeader: isNewSection ? `### ${sectionName}` : null
-  };
-}
 
 /// Extract PR flavor from title or branch name
 function extractPRFlavor(prTitle, prBranchRef) {
@@ -160,6 +75,5 @@ function extractPRFlavor(prTitle, prBranchRef) {
 module.exports = {
   FLAVOR_CONFIG,
   getFlavorConfig,
-  findChangelogInsertionPoint,
   extractPRFlavor
 };

danger/dangerfile-utils.test.js

@@ -1,6 +1,6 @@
 const { describe, it } = require('node:test');
 const assert = require('node:assert');
-const { getFlavorConfig, findChangelogInsertionPoint, extractPRFlavor, FLAVOR_CONFIG } = require('./dangerfile-utils.js');
+const { getFlavorConfig, extractPRFlavor, FLAVOR_CONFIG } = require('./dangerfile-utils.js');
 
 describe('dangerfile-utils', () => {
   describe('getFlavorConfig', () => {
@@ -143,118 +143,6 @@ describe('dangerfile-utils', () => {
     });
   });
 
-  describe('findChangelogInsertionPoint', () => {
-    it('should find insertion point in existing section', () => {
-      const changelog = [
-        '# Changelog',
-        '',
-        '## Unreleased',
-        '',
-        '### Features',
-        '',
-        '- Some existing feature ([#123](...))',
-        '',
-        '## 1.0.0'
-      ];
-
-      const result = findChangelogInsertionPoint(changelog, 'Features');
-      assert.strictEqual(result.success, true);
-      assert.strictEqual(result.lineNumber, 8); // Should insert after existing feature
-      assert.strictEqual(result.isNewSection, false);
-      assert.strictEqual(result.sectionHeader, null);
-    });
-
-    it('should create new section when section does not exist', () => {
-      const changelog = [
-        '# Changelog',
-        '',
-        '## Unreleased',
-        '',
-        '### Features',
-        '',
-        '- Some existing feature ([#123](...))',
-        '',
-        '## 1.0.0'
-      ];
-
-      const result = findChangelogInsertionPoint(changelog, 'Security');
-      assert.strictEqual(result.success, true);
-      assert.strictEqual(result.isNewSection, true);
-      assert.strictEqual(result.sectionHeader, '### Security');
-      // Should insert before existing Features section
-      assert.strictEqual(result.lineNumber, 5);
-    });
-
-    it('should handle changelog with no existing sections', () => {
-      const changelog = [
-        '# Changelog',
-        '',
-        '## Unreleased',
-        '',
-        '## 1.0.0'
-      ];
-
-      const result = findChangelogInsertionPoint(changelog, 'Features');
-      assert.strictEqual(result.success, true);
-      assert.strictEqual(result.isNewSection, true);
-      assert.strictEqual(result.sectionHeader, '### Features');
-      // Should insert after Unreleased header
-      assert.strictEqual(result.lineNumber, 4);
-    });
-
-    it('should fail when no Unreleased section exists', () => {
-      const changelog = [
-        '# Changelog',
-        '',
-        '## 1.0.0',
-        '',
-        '- Initial release'
-      ];
-
-      const result = findChangelogInsertionPoint(changelog, 'Features');
-      assert.strictEqual(result.success, false);
-    });
-
-    it('should handle empty section', () => {
-      const changelog = [
-        '# Changelog',
-        '',
-        '## Unreleased',
-        '',
-        '### Features',
-        '',
-        '### Fixes',
-        '',
-        '- Some fix ([#456](...))',
-        '',
-        '## 1.0.0'
-      ];
-
-      const result = findChangelogInsertionPoint(changelog, 'Features');
-      assert.strictEqual(result.success, true);
-      assert.strictEqual(result.isNewSection, false);
-      // Should insert in empty Features section
-      assert.strictEqual(result.lineNumber, 7);
-    });
-
-    it('should be case-insensitive for section matching', () => {
-      const changelog = [
-        '# Changelog',
-        '',
-        '## unreleased',
-        '',
-        '### features',
-        '',
-        '- Some existing feature ([#123](...))',
-        '',
-        '## 1.0.0'
-      ];
-
-      const result = findChangelogInsertionPoint(changelog, 'Features');
-      assert.strictEqual(result.success, true);
-      assert.strictEqual(result.isNewSection, false);
-    });
-  });
 
   describe('FLAVOR_CONFIG integrity', () => {
     it('should have unique labels across all configs', () => {