Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Add automated memory leak sanity/regression tests #297

Closed
LewisJEllis opened this issue Mar 16, 2017 · 1 comment
Closed

Add automated memory leak sanity/regression tests #297

LewisJEllis opened this issue Mar 16, 2017 · 1 comment

Comments

@LewisJEllis
Copy link
Contributor

We want to avoid issues like #295 as much as possible, so we're going to start automatically exercising the most memory-leak-prone parts of raven as a sanity/regression test for memory usage. The plan is to build a harness that lets us just run a bunch of calls through whatever thing (contexts, instrumentation, etc) and then follow memory with memwatch and fail a test case if numbers don't look right. A loose skeleton of this is already done from tracking down the memory leak in #295.

Things to do this check for:

  • Having lots of different ephemeral contexts
  • Lots of manual captureBreadcrumbing
  • each autoBreadcrumb instrumentation
    • console, http, pg
    • any added in future

The goal is that if these tests had been in place, the change that caused #295 would not have passed CI. This will also increase confidence in future additional instrumentation.

@LewisJEllis
Copy link
Contributor Author

We built these memory tests in #300 except for the "automated" part. Did not automate because it's hard to programmatically know whether the numbers the tests produce are acceptable; it's easier and good enough IMO to, before cutting any release, manually run the memory tests and take a look over the numbers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant