Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v3 Branch Pick] Exclude all 4xx Rails errors #1004

Merged
merged 1 commit into from
Aug 28, 2020
Merged

[v3 Branch Pick] Exclude all 4xx Rails errors #1004

merged 1 commit into from
Aug 28, 2020

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Aug 28, 2020

This PR picks the changes of #769

@st0012 st0012 added this to the 3.1.0 milestone Aug 28, 2020
@st0012 st0012 self-assigned this Aug 28, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2020 •
edited
Loading

Codecov Report

Merging #1004 into v3-1 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             v3-1    #1004   +/-   ##
=======================================
  Coverage   97.85%   97.85%           
=======================================
  Files          46       46           
  Lines        2187     2187           
=======================================
  Hits         2140     2140           
  Misses         47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c25ea2c...4883e3c. Read the comment docs.

@st0012 st0012 changed the base branch from master to v3-1 August 28, 2020 07:46
@st0012 st0012 changed the title [V3 Branch Pick] Exclude all 4xx Rails errors [v3 Branch Pick] Exclude all 4xx Rails errors Aug 28, 2020
@st0012 st0012 merged commit 6d9f59c into v3-1 Aug 28, 2020
@st0012 st0012 deleted the pick-#769 branch August 28, 2020 07:54
st0012 added a commit that referenced this pull request Aug 28, 2020
@st0012 @nateberkopec
Exclude all 4xx Rails errors (#1004)
bb9d6b0 
Co-authored-by: Nate Berkopec <nate.berkopec@gmail.com>
agrobbin
agrobbin reviewed Oct 27, 2020
View reviewed changes
lib/raven/configuration.rb
'ActionController::UnknownFormat',
'ActionController::UnknownHttpMethod',
'ActionDispatch::Http::Parameters::ParseError',
'ActionView::MissingTemplate',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@st0012 I'm not sure what the current state of the v3 branch is, but the inclusion of ActionView::MissingTemplate here feels like a bug. While Rails does render a 406 Not Acceptable when ActionView::MissingExactTemplate is raised, it renders a 500 Internal Server Error when ActionView::MissingTemplate is raised (via its default error handling).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I think it's too aggressive to exclude the ActionView::MissingTemplate by default. will remove it in the upcoming version. thanks for the opinion 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added #1092 to remove it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @st0012!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrobbin agrobbin agrobbin left review comments

Assignees

@st0012 st0012

Labels
enhancement
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@st0012 @codecov-commenter @agrobbin @nateberkopec