Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(server): Simplify CheckEnvelope #1429

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Conversation

jan-auer
Copy link
Member

Since #1416 the CheckEnvelope message no longer needs to return scoping. This is
now passed through the EnvelopeContext. This PR removes dead fields and cleans
up code around it.

#skip-changelog

@jan-auer jan-auer requested a review from a team August 19, 2022 12:14
Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loves red PRs. :shipit:

@jan-auer jan-auer enabled auto-merge (squash) August 19, 2022 12:27
@jan-auer jan-auer merged commit db3112c into master Aug 19, 2022
@jan-auer jan-auer deleted the ref/simplify-check-envelope branch August 19, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants