Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INC-263] Backoff mechanism for fetching projects in case of error #1633

Closed
jan-auer opened this issue Nov 24, 2022 · 1 comment · Fixed by #1726
Closed

[INC-263] Backoff mechanism for fetching projects in case of error #1633

jan-auer opened this issue Nov 24, 2022 · 1 comment · Fixed by #1726
Assignees
Labels
bug Something isn't working

Comments

@jan-auer
Copy link
Member

With #1426 deployed in case of invalid project state (when it could not be parsed or fetched) we will reuse the old state up until the grace period is reached.

This does not stop the Relay to try and update the state in next refresh cycle again though. We must make sure that we have a back off for these retries so we won’t DDoS our own services with requests.

@jan-auer jan-auer added the bug Something isn't working label Nov 24, 2022
@jan-auer
Copy link
Member Author

@jjbayer wrote:

We have a backup mechanism, but it is only used if the upstream does not respond at all, not for invalid project configs:

// If a single request succeeded we reset the backoff. We decided to
// only backoff if we see that the project config endpoint is
// completely down and did not answer a single request successfully.
//
// Otherwise we might refuse to fetch any project configs because of a
// single, reproducible 500 we observed for a particular project.
slf.backoff.reset();

@jan-auer jan-auer changed the title Backoff mechanism for fetching projects in case of error [INC-263] Backoff mechanism for fetching projects in case of error Dec 6, 2022
@olksdr olksdr self-assigned this Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants