-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new replay context to the context protocol #1792
Comments
The information in this context seems to contain metadata on sampling. This information is usually not stored in the event payload but rather in special metadata keys (either
We may need to move some of these fields to other places in the payload. |
@jan-auer The fields are supplied to relay as a "replay" object within the "contexts" object containing two keys with float values. {
"contexts": {
"replay": {
"error_sample_rate": f64,
"session_sample_rate": f64
}
...
}
} The values are not used within the product and are instead used for internal metrics calculations. @mydea knows more and can give more details on usage. |
I am running into this now in #1983 as I didn't realize we already were setting things in the context. I think that we shouldn't store these on the replay context, and need to rethink these fields. let's discuss soon. |
@cmanallen is this still relevant? Closing because of age, feel free to reopen. |
This can go into a separate PR, but we should add this new Context to the protocol. see for example
relay/relay-general/src/protocol/contexts/browser.rs
Lines 6 to 16 in 23c24a9
Originally posted by @jjbayer in #1791 (comment)
The text was updated successfully, but these errors were encountered: