Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multer instead of axum's multipart #2218

Closed
jan-auer opened this issue Jun 14, 2023 · 0 comments · Fixed by #3978
Closed

Use multer instead of axum's multipart #2218

jan-auer opened this issue Jun 14, 2023 · 0 comments · Fixed by #3978
Labels
filler Requires little effort to resolve. Ready to be picked up anytime. maintenance Tasks with this label generally have a lower priority and due date

Comments

@jan-auer
Copy link
Member

Axum has a multipart extractor that opaquely wraps multer::Multipart. It lacks two essential APIs:

  • Options cannot be configured, such as size limits for individual items. We require these limits and currently have implemented a hack to enforce them.
  • The error is opaque, but we would like to inspect and react to the variants.

Since we already use multer for parsing nested multipart bodies, we can remove the multipart feature from axum and implement a simple extractor wrapper ourselves.

@jan-auer jan-auer added filler Requires little effort to resolve. Ready to be picked up anytime. maintenance Tasks with this label generally have a lower priority and due date labels Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filler Requires little effort to resolve. Ready to be picked up anytime. maintenance Tasks with this label generally have a lower priority and due date
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant