Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose relay metrics protocol to clients #2449

Closed
6 tasks done
iambriccardo opened this issue Aug 31, 2023 · 2 comments
Closed
6 tasks done

Expose relay metrics protocol to clients #2449

iambriccardo opened this issue Aug 31, 2023 · 2 comments
Assignees

Comments

@iambriccardo
Copy link
Member

iambriccardo commented Aug 31, 2023

The StatsD protocol Relay has implemented so far is a DataDog flavor, called the "DogStatsD protocol". On top of vanilla statsd, this protocol offers these additional options:

  1. Tags. This has been implemented from the start
  2. Sample rates. Not implemented, TBD.
  3. Value packing. Not implemented and should be added.
  4. Container IDs. Not implemented, but also not needed.
  5. Timestamps. Implemented with a different syntax, can be aligned.

There's no reason that our submission protocol diverges from DogStatsD, so we can implement full compatibility with this protocol. Along with this change, Relay can parse all metric payloads directly into buckets, rather than a separate metric type.

@jan-auer
Copy link
Member

jan-auer commented Sep 1, 2023

I'll compare with protocols from existing collectors first and then bring forward a proposal for improvements.

@jan-auer
Copy link
Member

jan-auer commented Sep 5, 2023

Completed.

@jan-auer jan-auer closed this as completed Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants