-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrub auth tokens anywhere #2567
Comments
Actions:
|
Maybe related: A user sends a Breadcrumb that contains sensitive data in the breadcrumb message (see reproduction event here: https://sentry-sdks.sentry.io/issues/4535377485/?project=5461230&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=30d&stream_index=4 ) The breadcrumb message string contains |
I'd start with implementing this on the server, and probably just have it be a "scrub-next-token" behavior if the value is identified in a tuple/list. Obviously you could look for tuples, and I'm sure next token won't always be valid, but given the intent of scrubbers its always better to be safe. |
Option 1 was implemented with #3484 |
Currently we do not scrub bearer tokens everywhere, e.g.
We do not treat
["authorization", "Bearer abc123"]
as a key-value pair, so we scrub the key, but not the value (see code).Possible solutions:
Bearer <hex>
anywhere in a string (as we do for credit card numbers).The text was updated successfully, but these errors were encountered: