Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly Parse SQL query when db.system is provided #2847

Closed
Fwang36 opened this issue Dec 12, 2023 · 3 comments
Closed

Correctly Parse SQL query when db.system is provided #2847

Fwang36 opened this issue Dec 12, 2023 · 3 comments
Assignees
@jjbayer
Labels
bug Something isn't working

Comments

@Fwang36
Copy link
Member

Fwang36 commented Dec 12, 2023 •
edited
Loading

Environment

SaaS (https://sentry.io/)

This is an issue created following an internal slack discussion.

A user has correctly added the span data value of db.system of mysql. Sentry is failing to parse some queries even though the db.system is being provided. This has led the user's queries to be blocked by Sentry due to high cardinality.

User's Project Id and Org will be in the synced Jira Ticket.

Jira
@getsantry
Copy link

getsantry bot commented Dec 12, 2023

Assigning to @getsentry/support for routing ⏲️

@Fwang36 Fwang36 transferred this issue from getsentry/sentry Dec 12, 2023
@getsantry getsantry bot moved this from Waiting for: Support to Waiting for: Product Owner in GitHub Issues with 👀 Dec 12, 2023
@getsantry getsantry bot removed the status in GitHub Issues with 👀 Dec 12, 2023
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Dec 12, 2023
@jjbayer jjbayer added the bug Something isn't working label Dec 13, 2023
@getsantry getsantry bot removed the status in GitHub Issues with 👀 Dec 13, 2023
@jjbayer jjbayer mentioned this issue Dec 13, 2023
Merged
@jjbayer jjbayer self-assigned this Dec 13, 2023
@jjbayer
Copy link
Member

jjbayer commented Dec 14, 2023

This will be at least partially fixed by apache/datafusion-sqlparser-rs#1065.

@jjbayer
Copy link
Member

jjbayer commented Dec 21, 2023

Looks like this was largely fixed by #2846.

@jjbayer jjbayer closed this as completed Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjbayer jjbayer

Labels
bug Something isn't working
Projects
GitHub Issues with 👀
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jjbayer @Fwang36