-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loosen domain name scrubbing in span.domain
tag
#3573
Comments
Domain scrubbing is definitely arbitrary right now, because the second level domain might be just as high-cardinality as the subdomain. @gggritso what if we approach this in a data-driven way, i.e. collect a sample of unscrubbed domains from from the spans dataset and see what kind of scrubbing would yield the best results? One thing we could immediately evaluate is subdomain removal vs. scrubbing of integer / hex IDs. Is this something you'd be willing to drive? |
I think I'd prefer this one:
It doesn't disturbs the behavior on SaaS and it has a toggle for it. |
@jjbayer that approach makes sense! I'd be happy to do that at some point, though not sure when I'll have a chance |
Since the implementation on #3813 also works for this issue, we should close it. |
Problem Statement
Relay scrubs domain addresses like
my.app.service.com
to something like*.service.com
. This is okay for a lot of cases, but for some users, subdomains are meaningful to more than just 2 segments. This scrubbing causes different domains to be mashed together in the Requests view.Solution Brainstorm
The text was updated successfully, but these errors were encountered: