Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: text node in <noscript> element is being rendered in playback #184

Open
1 task done
billyvg opened this issue Apr 23, 2024 · 1 comment
Open
1 task done
Labels
bug Something isn't working

Comments

@billyvg
Copy link
Member

billyvg commented Apr 23, 2024

Preflight Checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.

What package is this bug report for?

rrweb

Version

latest

Expected Behavior

The text node inside of a <noscript> should not be rendered.

Actual Behavior

The text inside of <noscript> is being rendered as a string on playback.

Steps to Reproduce

See this zendesk ticket

Testcase Gist URL

No response

Additional Information

No response

@billyvg billyvg added the bug Something isn't working label Apr 23, 2024
@billyvg
Copy link
Member Author

billyvg commented Apr 23, 2024

After debugging, this seems to happen only in sentry when we have an initial offset (e.g. t=<number> query param). Roughly what happens is:

  • we inject some default css including noscript { display: none; }
  • call play(offset)
  • --> call applyEventsSynchronously
  • ----> uses virtualDOM
  • ------> does not copy over the styles that were injected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant