Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop breaking sentry CI #1297

Closed
chadwhitacre opened this issue Feb 4, 2022 · 6 comments · Fixed by #1301
Closed

Stop breaking sentry CI #1297

chadwhitacre opened this issue Feb 4, 2022 · 6 comments · Fixed by #1301

Comments

@chadwhitacre
Copy link
Member

#1289 broke CI again over in sentry again, resulting in INC-98 (private).
@aminvakil
Copy link
Collaborator

Maybe reopen #1267 (comment) again?

@chadwhitacre
Copy link
Member Author

Possibly, would like to do a little digging first ...

@chadwhitacre
Copy link
Member Author

Here's a failed run.

@chadwhitacre chadwhitacre mentioned this issue Feb 4, 2022
Merged
@chadwhitacre
Copy link
Member Author

Garbaged confirmed.

Step #4 - "e2e-test": Failed to create relay credentials in ../relay/credentials.json.
Step #4 - "e2e-test": --- credentials.json v ---------------------------------------
Step #4 - "e2e-test": nightly: Pulling from getsentry/relay
Step #4 - "e2e-test": Digest: sha256:8f108ca1ae7348b20d58b88fb32c6e34e5d03b4bbbaf73255aae6804ea7c8519
Step #4 - "e2e-test": Status: Downloaded newer image for getsentry/relay:nightly
Step #4 - "e2e-test": {"secret_key":"Dgpto8zNBtqFAdE0IXtbPgk5agM7wN5Xvohn88nNoWg","public_key":"wsbB9DXcvL5L59LcFFZ7c4ELeUTtU6yq3hidtl4XxN4","id":"4e38f085-206a-4a49-93f2-e771a853ba6d"}
Step #4 - "e2e-test": --- credentials.json ^ ---------------------------------------

@chadwhitacre
Copy link
Member Author 

Step #4 - "e2e-test": Found Docker version 20.10.12
Step #4 - "e2e-test": Found Docker Compose version 1.29.2

@chadwhitacre chadwhitacre mentioned this issue Feb 4, 2022
Merged
@chadwhitacre
Copy link
Member Author

Confirmed in https://github.com/getsentry/sentry/runs/5073987281. 👍

Step #4 - "e2e-test": Relay credentials written to ../relay/credentials.json.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pull relay explicitly to avoid garbage in creds getsentry/self-hosted
2 participants
@chadwhitacre @aminvakil