Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags for 24.5.x removed #3172

Closed
dlouzan opened this issue Jun 28, 2024 · 5 comments
Closed

Tags for 24.5.x removed #3172

dlouzan opened this issue Jun 28, 2024 · 5 comments

Comments

@dlouzan
Copy link

dlouzan commented Jun 28, 2024

Self-Hosted Version

CPU Architecture

Docker Version

Docker Compose Version

Steps to Reproduce

We deployed 24.5.0 last month and we just realized that the tags are gone. Was this intended? The changelog still lists them though: https://github.com/getsentry/self-hosted/blob/master/CHANGELOG.md

Expected Result

Tags for 24.5.0 and 24.5.1 are available.

Actual Result

No tags available: https://github.com/getsentry/self-hosted/tags

Event ID

No response

@dlouzan
Copy link
Author

dlouzan commented Jun 28, 2024

/cc @max-wittig @ercanucan

@hubertdeng123
Copy link
Member

Yes, this was intentional. See here for more details:
#3167

@liukch
Copy link

liukch commented Jul 2, 2024

Yes, this was intentional. See here for more details: #3167

No!!!! Please do not do that. A lot of people use these version in prod env. What if they meet some accident, where for them to find out these code?

This is irreversible. The correct approach is to add some comments in a prominent position for version 24.6.x.

@max-wittig
Copy link
Contributor

I agree with @liukch. We had to run REINDEX index sentry_groupedmessage_view; for the DB upgrade to succeed and after reading the comments in #3167, I'm not sure that this was enough.

I know this is free software and we cannot expect anything, but this is not a way to handle upgrades.

@dlouzan
Copy link
Author

dlouzan commented Jul 2, 2024

Well, I agree with the other posters that removing git tags is a pretty weird move, but I guess since there's no packages you have no way to "yank" a version. We'll keep an eye on the linked issues. Thanks!

@dlouzan dlouzan closed this as completed Jul 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Archived in project
Development

No branches or pull requests

4 participants