Method addObserver must be called on the main thread #520

lewisf · 2020-08-14T19:02:06Z

Platform:

iOS
Android

SDK:

@sentry/react-native (>= 1.0.0)
react-native-sentry (<= 0.43.2)

RN SDK version: 1.6.3
Android SDK version: 2.2.0

react-native version: 0.62.17

Are you using Expo?

Yes
No

Are you using sentry.io or on-premise?

sentry.io (SaaS)
on-premise

If you are using sentry.io, please post a link to your issue so we can take a look:

https://sentry.io/organizations/persona-identities-inc/issues/1839866967/?project=5378601&query=is%3Aunresolved

Configuration:

(@sentry/react-native)

Sentry.init({
  dsn: 'https://...@sentry.io/...'
});

I have following issue:

I went through barebones setup steps and am getting this error. Commenting out the Sentry.init gets rid of it. Stack trace seems to indicate it's all happening within the Sentry library but I'm not sure if I'm doing something wrong.

Steps to reproduce:

New project on React Native 0.62.17
Install Sentry
Launch in Android Emulator using Pixel 2 API 29
Red screen with error

Actual result:

Expected result:

No error.

The text was updated successfully, but these errors were encountered:

jennmueng · 2020-08-17T09:31:07Z

Hmm this error is coming from the Android SDK, can you please indicate the SDK version and React Native version that you're using? Thanks.

lewisf · 2020-08-17T16:34:10Z

@jennmueng, thanks for the quick response!

react-native is 0.62.17

"@sentry/react-native@1.6.3":
  version "1.6.3"
  resolved "https://registry.yarnpkg.com/@sentry/react-native/-/react-native-1.6.3.tgz#80c68d6bc7f10bd4b7eb12e1b028620a1fadbcc5"
  integrity sha512-0nkPV/QWEXWQb67XKy4HY9x8zLEURzBT7xaal2KUGRWu2JGObfy5eYk8+k+XsGLVAMfelCkcLQWNneUY80reng==
  dependencies:
    "@sentry/browser" "^5.19.0"
    "@sentry/core" "^5.19.0"
    "@sentry/hub" "^5.19.0"
    "@sentry/integrations" "^5.19.0"
    "@sentry/types" "^5.19.0"
    "@sentry/utils" "^5.19.0"
    "@sentry/wizard" "^1.1.4"

jennmueng · 2020-08-18T08:36:12Z

Ok so the React Native SDK @ 1.6.3 would depend on sentry-android:2.2.0. I'll move this issue over to our Android SDK as I think my colleagues over there would be more knowledgable to help you out with this error.

lewisf · 2020-08-18T20:25:06Z

Thanks. Is there anything else I can do to help with debugging?

haelsisy · 2020-08-23T18:39:39Z

I have the same issue with react-native

    "react": "16.11.0",
    "react-native": "0.62.2",
    "@sentry/react-native": "^1.7.1"

marandaneto · 2020-08-24T08:00:07Z

hey thanks for reporting this, quick question:

are you initing the Android SDK manually by yourself or are you letting the Sentry RN SDK do the job automatically?

If you are letting the Sentry RN SDK do the job, on which life cycle (which class/method) of the RN App. are ou initing the Sentry RN SDK? thanks :)

marandaneto · 2020-08-24T08:48:24Z

@lewisf @zumaawad what version of the androidx.lifecycle/lifecycle-process lib are you working with btw? are you referencing directly or is it a transitive dependency? could you track this down, please? 2.2.0 doesn't have this check enforceMainThreadIfNeeded but maybe an older version has it.

marandaneto · 2020-08-24T08:58:17Z

as you can see, this has been changed in the lib and ideally, we'd add a main thread checker to avoid this problem.

1st commit: https://android.googlesource.com/platform/frameworks/support/+/1a587cf583809379add635a9047ded82d44306c8
2nd commit: https://android.googlesource.com/platform/frameworks/support/+/5675f1a128d0c3878ba97e74ef3aad521071a63b
3nd commit: https://android.googlesource.com/platform/frameworks/support/+/a9a8ffd7d455ff81f81f5c71bb300b6acab823ba

marandaneto · 2020-08-24T09:27:28Z

as a workaround, you can disable the lifecycle breadcrumbs for now:

https://docs.sentry.io/platforms/android/#default-context-for-android

<application>
    <!--     To disable the app lifecycle breadcrumbs integration-->
    <meta-data android:name="io.sentry.breadcrumbs.app-lifecycle" android:value="false" />
</application>

haelsisy · 2020-08-24T09:28:17Z

@marandaneto I'm using RN SDK and I initiate in app.js

haelsisy · 2020-08-24T11:00:44Z

@marandaneto Still the same

E/unknown:ReactNative: Exception in native call java.lang.IllegalStateException: Method addObserver must be called on the main thread at androidx.lifecycle.LifecycleRegistry.enforceMainThreadIfNeeded(LifecycleRegistry.java:317) at androidx.lifecycle.LifecycleRegistry.addObserver(LifecycleRegistry.java:172) at io.sentry.android.core.AppLifecycleIntegration.register(AppLifecycleIntegration.java:53) at io.sentry.core.Sentry.init(Sentry.java:159) at io.sentry.core.Sentry.init(Sentry.java:96) at io.sentry.android.core.SentryAndroid.init(SentryAndroid.java:59) at io.sentry.android.core.SentryAndroid.init(SentryAndroid.java:44) at io.sentry.RNSentryModule.startWithOptions(RNSentryModule.java:74) at java.lang.reflect.Method.invoke(Native Method) at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:372) at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:151) at com.facebook.react.bridge.queue.NativeRunnable.run(Native Method) at android.os.Handler.handleCallback(Handler.java:883) at android.os.Handler.dispatchMessage(Handler.java:100) at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27) at android.os.Looper.loop(Looper.java:214) at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:226) at java.lang.Thread.run(Thread.java:919)

marandaneto · 2020-08-24T11:30:13Z

@marandaneto Still the same

E/unknown:ReactNative: Exception in native call java.lang.IllegalStateException: Method addObserver must be called on the main thread at androidx.lifecycle.LifecycleRegistry.enforceMainThreadIfNeeded(LifecycleRegistry.java:317) at androidx.lifecycle.LifecycleRegistry.addObserver(LifecycleRegistry.java:172) at io.sentry.android.core.AppLifecycleIntegration.register(AppLifecycleIntegration.java:53) at io.sentry.core.Sentry.init(Sentry.java:159) at io.sentry.core.Sentry.init(Sentry.java:96) at io.sentry.android.core.SentryAndroid.init(SentryAndroid.java:59) at io.sentry.android.core.SentryAndroid.init(SentryAndroid.java:44) at io.sentry.RNSentryModule.startWithOptions(RNSentryModule.java:74) at java.lang.reflect.Method.invoke(Native Method) at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:372) at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:151) at com.facebook.react.bridge.queue.NativeRunnable.run(Native Method) at android.os.Handler.handleCallback(Handler.java:883) at android.os.Handler.dispatchMessage(Handler.java:100) at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:27) at android.os.Looper.loop(Looper.java:214) at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:226) at java.lang.Thread.run(Thread.java:919)

ups sorry, you also have to disable the session tracking as it depends on this 3rd party lib.

https://docs.sentry.io/platforms/react-native/#release-health

so if enableAutoSessionTracking is enabled, you've to disable it too, sorry about that.

haelsisy · 2020-08-24T13:37:57Z

@marandaneto Its working now with
"@sentry/react-native": "^1.6.2"
and
enableAutoSessionTracking is disabled
and
<application>  <meta-data android:name="io.sentry.breadcrumbs.app-lifecycle" android:value="false" /> </application>

marandaneto · 2020-08-24T13:41:56Z

@zumaawad good to know, mind answering the other question so we could choose the best solution? life cycle in the app.js file etc, thanks.

billnbell · 2020-08-24T15:02:47Z

I tried Sentry.init() in App.js and in index.android.js. Nothing helps. How about:
"@sentry/react-native": "^1.7.1" ?

haelsisy · 2020-08-24T15:33:16Z

@zumaawad good to know, mind answering the other question so we could choose the best solution? life cycle in the app.js file etc, thanks.

@marandaneto In componentDidMount

marandaneto · 2020-08-24T15:54:58Z

@zumaawad have you tried right before the App ReactNode?

eg:

import * as Sentry from '@sentry/react-native';

Sentry.init({ 
  dsn: '...',
  debug: true
});

const App: () => React$Node = () => {
  return (...)
}

haelsisy · 2020-08-24T15:59:14Z

@marandaneto I tired that too and didn’t work without workaround you mentioned before

marandaneto · 2020-08-24T16:00:33Z

@zumaawad ok, I will check if something has changed in the way how RN inits, we already have a PR to fix the issue anyway, getting feedback and will release a patch soon, thanks.

haelsisy · 2020-08-24T16:02:15Z

@marandaneto I think your PR #525 will fix this

marandaneto · 2020-08-24T16:04:35Z

@zumaawad indeed, but I wanna find out the source of this issue, as we've not changed anything on this repo about that, its either a change on sentry-react-native, on RN itself or you all have a transitive dependency of androidx.lifecycle/lifecycle-process that uses the main thread requirement, the latest is the most probably.

haelsisy · 2020-08-24T16:07:27Z

@marandaneto The fun fact is: we didn’t change anything from our side too 😄
Yes I think its related to android dependencies update

marandaneto · 2020-08-26T07:44:12Z

the Android SDK is published https://github.com/getsentry/sentry-android/releases/tag/2.3.1

you could upgrade this dependency in your build.gradle file or wait for a new version of the RN SDK which should come very soon as well.

path to upgrade the Android SDK:

something like: {project}/node_modules/@sentry/react-native/android/build.gradle
look for io.sentry:sentry-android

If you have applied the workarounds mentioned before, remember to revert it, so you don't lose the session tracking feature nor the app lifecycle breadcrumbs :)

marandaneto · 2020-08-26T09:08:04Z

RN SDK is also published https://github.com/getsentry/sentry-react-native/releases/tag/1.7.2

haelsisy · 2020-08-26T09:19:21Z

@marandaneto Thank you

lewisf · 2020-08-26T16:38:35Z

@marandaneto thanks!! appreciate the quick turnaround on this

jennmueng transferred this issue from getsentry/sentry-react-native Aug 18, 2020

marandaneto added the question Further information is requested label Aug 24, 2020

marandaneto added the dependencies Pull requests that update a dependency file label Aug 24, 2020

This was referenced Aug 24, 2020

Method addObserver must be called on the main thread getsentry/sentry-react-native#1035

Closed

fix: add main thread checker for the app lifecycle integration #525

Merged

marandaneto added the bug Something isn't working label Aug 24, 2020

marandaneto mentioned this issue Aug 25, 2020

Bump: sentry-android to v2.3.1 getsentry/sentry-react-native#1041

Merged

8 tasks

marandaneto closed this as completed Aug 26, 2020

This was referenced Jan 24, 2021

[Android] Error on setup: "Method addObserver must be called on the main thread" segmentio/analytics-react-native#255

Closed

java.lang.IllegalStateException when initialising Segment segmentio/analytics-android#725

Closed

wmonecke mentioned this issue Apr 23, 2021

🔥 Method addObserver must be called on the main thread timfpark/react-native-location#154

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Method addObserver must be called on the main thread #520

Method addObserver must be called on the main thread #520

lewisf commented Aug 14, 2020 •

edited

Loading

jennmueng commented Aug 17, 2020

lewisf commented Aug 17, 2020 •

edited

Loading

jennmueng commented Aug 18, 2020

lewisf commented Aug 18, 2020

haelsisy commented Aug 23, 2020

marandaneto commented Aug 24, 2020

marandaneto commented Aug 24, 2020 •

edited

Loading

marandaneto commented Aug 24, 2020

marandaneto commented Aug 24, 2020

haelsisy commented Aug 24, 2020

haelsisy commented Aug 24, 2020

marandaneto commented Aug 24, 2020

haelsisy commented Aug 24, 2020 •

edited

Loading

marandaneto commented Aug 24, 2020

billnbell commented Aug 24, 2020 •

edited

Loading

haelsisy commented Aug 24, 2020 •

edited

Loading

marandaneto commented Aug 24, 2020 •

edited

Loading

haelsisy commented Aug 24, 2020

marandaneto commented Aug 24, 2020

haelsisy commented Aug 24, 2020

marandaneto commented Aug 24, 2020 •

edited

Loading

haelsisy commented Aug 24, 2020

marandaneto commented Aug 26, 2020

marandaneto commented Aug 26, 2020

haelsisy commented Aug 26, 2020

lewisf commented Aug 26, 2020

Method addObserver must be called on the main thread #520

Method addObserver must be called on the main thread #520

Comments

lewisf commented Aug 14, 2020 • edited Loading

jennmueng commented Aug 17, 2020

lewisf commented Aug 17, 2020 • edited Loading

jennmueng commented Aug 18, 2020

lewisf commented Aug 18, 2020

haelsisy commented Aug 23, 2020

marandaneto commented Aug 24, 2020

marandaneto commented Aug 24, 2020 • edited Loading

marandaneto commented Aug 24, 2020

marandaneto commented Aug 24, 2020

haelsisy commented Aug 24, 2020

haelsisy commented Aug 24, 2020

marandaneto commented Aug 24, 2020

haelsisy commented Aug 24, 2020 • edited Loading

marandaneto commented Aug 24, 2020

billnbell commented Aug 24, 2020 • edited Loading

haelsisy commented Aug 24, 2020 • edited Loading

marandaneto commented Aug 24, 2020 • edited Loading

haelsisy commented Aug 24, 2020

marandaneto commented Aug 24, 2020

haelsisy commented Aug 24, 2020

marandaneto commented Aug 24, 2020 • edited Loading

haelsisy commented Aug 24, 2020

marandaneto commented Aug 26, 2020

marandaneto commented Aug 26, 2020

haelsisy commented Aug 26, 2020

lewisf commented Aug 26, 2020

lewisf commented Aug 14, 2020 •

edited

Loading

lewisf commented Aug 17, 2020 •

edited

Loading

marandaneto commented Aug 24, 2020 •

edited

Loading

haelsisy commented Aug 24, 2020 •

edited

Loading

billnbell commented Aug 24, 2020 •

edited

Loading

haelsisy commented Aug 24, 2020 •

edited

Loading

marandaneto commented Aug 24, 2020 •

edited

Loading

marandaneto commented Aug 24, 2020 •

edited

Loading