Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align RewriteFrames trimming. #567

Closed
lucas-zimerman opened this issue Feb 7, 2024 · 1 comment
Closed

Align RewriteFrames trimming. #567

lucas-zimerman opened this issue Feb 7, 2024 · 1 comment
Labels
Breaking-change should go in a major release (breaks apps, changes default configs in a major way) Platform: Capacitor question Further information is requested

Comments

@lucas-zimerman
Copy link
Collaborator

I noticed that on Sentry React Native the following StackTrace

        'at this(/home/username/sample-workspace/sampleapp.collect.capacitor/node_modules/capacitor/Libraries/Renderer/src/renderers/native/capacitorNativeBaseComponent.js:74:41)\n',

becomes

app:///capacitorNativeBaseComponent.js

where on capacitor it becomes

app:///home/username/sample-workspace/sampleapp.collect.capacitor/node_modules/capacitor/Libraries/Renderer/src/renderers/native/capacitorNativeBaseComponent.js

This doesn't seems to affect the stacktrace as seen below, but ideally, we should Align if we keep this behaviour or migrate to the one used by React Native
image

@github-project-automation github-project-automation bot moved this to Needs Discussion in Mobile & Cross Platform SDK Feb 7, 2024
@lucas-zimerman lucas-zimerman added question Further information is requested Breaking-change should go in a major release (breaks apps, changes default configs in a major way) labels Feb 7, 2024
@lucas-zimerman
Copy link
Collaborator Author

It was decided to keep the current behaviour and we'll not follow how it's done on React Native

@github-project-automation github-project-automation bot moved this from Needs Discussion to Done in Mobile & Cross Platform SDK Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking-change should go in a major release (breaks apps, changes default configs in a major way) Platform: Capacitor question Further information is requested
Projects
Archived in project
Development

No branches or pull requests

1 participant