Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align in_app from RewriteFrames #568

Closed
lucas-zimerman opened this issue Feb 7, 2024 · 2 comments
Closed

Align in_app from RewriteFrames #568

lucas-zimerman opened this issue Feb 7, 2024 · 2 comments
Labels
Breaking-change should go in a major release (breaks apps, changes default configs in a major way) Platform: Capacitor question Further information is requested

Comments

@lucas-zimerman
Copy link
Collaborator

I noticed that there are some differences between the React Native SDK and the Capacitor one.

for instance
[native code] is flagged as true on React Native and false on Capacitor.

we should align the usage of in_app on Capacitor if it should be kept as is or changed to the way React Native is using.

@github-project-automation github-project-automation bot moved this to Needs Discussion in Mobile & Cross Platform SDK Feb 7, 2024
@lucas-zimerman lucas-zimerman added question Further information is requested Breaking-change should go in a major release (breaks apps, changes default configs in a major way) and removed Platform: Capacitor labels Feb 7, 2024
@kahest
Copy link
Member

kahest commented Feb 16, 2024

Let's find out what the differences are and why they are, then we can decide whether we want to align the behavior

@kahest kahest moved this from Needs Discussion to Needs Investigation in Mobile & Cross Platform SDK Feb 16, 2024
@lucas-zimerman
Copy link
Collaborator Author

We decided that we will keep the original behaviour

@github-project-automation github-project-automation bot moved this from Needs Investigation to Done in Mobile & Cross Platform SDK Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking-change should go in a major release (breaks apps, changes default configs in a major way) Platform: Capacitor question Further information is requested
Projects
Archived in project
Development

No branches or pull requests

2 participants