consolidate some redundant codepaths

Author: armcknight

Samples/iOS-Swift/iOS-Swift-UITests/ProfilingUITests.swift

@@ -165,14 +165,14 @@ extension ProfilingUITests {
 
         switch profileType {
         case .ui:
+            app.launchEnvironment["--io.sentry.profile-session-sample-rate"] = "1"
             switch lifecycle {
             case .none:
                 fatalError("Misconfigured test case. Must provide a lifecycle for UI profiling.")
             case .trace:
-                app.launchEnvironment["--io.sentry.profile-session-sample-rate"] = "1"
+                break
             case .manual:
                 app.launchArguments.append("--io.sentry.profile-lifecycle-manual")
-                app.launchEnvironment["--io.sentry.profile-session-sample-rate"] = "1"
             }
         case .continuous:
             app.launchArguments.append("--io.sentry.disable-ui-profiling")

Sources/Sentry/Profiling/SentryLaunchProfiling.m

@@ -153,7 +153,8 @@
         return (SentryLaunchProfileConfig) { NO, nil, nil };
     }
 
-    SENTRY_LOG_DEBUG(@"Continuous profiling v2 conditions satisfied, will profile launch.");
+    SENTRY_LOG_DEBUG(
+        @"Continuous profiling v2 manual lifecycle conditions satisfied, will profile launch.");
     return (SentryLaunchProfileConfig) { YES, nil, profileSampleDecision };
 }
 
@@ -164,12 +165,8 @@
         return sentry_launchShouldHaveContinuousProfilingV2(options);
     }
 
-    if ([options isContinuousProfilingEnabled] && options.enableAppLaunchProfiling) {
-        return (SentryLaunchProfileConfig) { YES, nil, nil };
-    }
-
     if ([options isContinuousProfilingEnabled]) {
-        return (SentryLaunchProfileConfig) { NO, nil, nil };
+        return (SentryLaunchProfileConfig) { options.enableAppLaunchProfiling, nil, nil };
     }
 
     return sentry_launchShouldHaveTransactionProfiling(options);

Sources/Sentry/SentryFileManager.m

@@ -858,6 +858,7 @@ - (BOOL)isDirectory:(NSString *)path
 writeAppLaunchProfilingConfigFile(NSMutableDictionary<NSString *, NSNumber *> *config)
 {
     NSError *error;
+    SENTRY_LOG_DEBUG(@"Writing launch profiling config file.");
     SENTRY_CASSERT([config writeToURL:launchProfileConfigFileURL() error:&error],
         @"Failed to write launch profile config file: %@.", error);
 }