test(UI): always wipe all data on disk before starting a new UI test (#5436)

* test: always wipe all data on disk before starting a new UI test

* do it in BaseUITest.setUp so it only happens once per test case, on the first launch

Author: armcknight

Samples/iOS-Swift/iOS-Swift-UITests/BaseUITest.swift

@@ -13,6 +13,9 @@ class BaseUITest: XCTestCase {
         continueAfterFailure = false
         XCUIDevice.shared.orientation = .portrait
         app.launchEnvironment["--io.sentry.sdk-environment"] = "ui-tests"
+        app.launchArguments.append(contentsOf: [
+            "--io.sentry.wipe-data"
+        ])
         if automaticallyLaunchAndTerminateApp {
             launchApp()
         }

Samples/iOS-Swift/iOS-Swift-UITests/ProfilingUITests.swift

@@ -6,14 +6,6 @@ import XCTest
 class ProfilingUITests: BaseUITest {
     override var automaticallyLaunchAndTerminateApp: Bool { false }
 
-    override func setUp() {
-        super.setUp()
-
-        app.launchArguments.append(contentsOf: [
-            "--io.sentry.wipe-data" // make sure there are no previous configuration files or profile files written
-        ])
-    }
-
     func testAppLaunchesWithTraceProfiler() throws {
         guard #available(iOS 16, *) else {
             throw XCTSkip("Only run for latest iOS version we test; we've had issues with prior versions in SauceLabs")