-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change SentryUser Swift name to something other than User #1100
Comments
Ah, if you just opened up this issue a few days earlier 😁. We just shipped 7.0.0. I add this to 8.0.0, so we can discuss this in the next major. I agree with you that we should change this. Thanks for pointing it out. |
Awesome! Glad it's on the roadmap! |
Maybe we could use a protocol and some subclassing to not make this a breaking change. |
2 tasks
6 tasks
5 tasks
Closed with #2403. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Obj-C
SentryUser
has a Swift name ofUser
viaNS_SWIFT_NAME(User)
.User
is an incredibly common class name in apps, and having this renamed toUser
in Swift causes a lot more issues than it needs to. If I have a class that uses both Sentry and my ownUser
class, I need to explicitly useMyModule.User
in order to avoid naming conflicts.I understand this would be a breaking change, but using the Sentry framework should provide as few roadblocks to using our own code as possible. Thanks!
The text was updated successfully, but these errors were encountered: