Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hints #2325

Open
Tracked by #4180
marandaneto opened this issue Oct 25, 2022 · 10 comments
Open
Tracked by #4180

Support hints #2325

marandaneto opened this issue Oct 25, 2022 · 10 comments

Comments

@marandaneto
Copy link
Contributor

marandaneto commented Oct 25, 2022

Description

This is needed for #1460 and #2650
Also for https://develop.sentry.dev/sdk/features/#http-client-errors -> PR
Hints are part of the Unified API.
Hints are generally a Map<String, Any>, on Java leverage the data bag with a typed class with helper methods.

@philipphofmann
Copy link
Member

If we add an overload for beforeSend with a hint we can do this without a breaking change.

@philipphofmann
Copy link
Member

On Java, we have typed hints. I think that would be better than having a Map<String, Any>.

@philipphofmann philipphofmann moved this from Backlog to Needs Discussion in Mobile & Cross Platform SDK Jul 18, 2023
@marandaneto
Copy link
Contributor Author

On Java, we have typed hints. I think that would be better than having a Map<String, Any>.

Yes, it used to be a Map, now it is a typed Hint, which is better.

@philipphofmann
Copy link
Member

Hints must allow capturing stacktraces only for one event if capture stacktraces is disabled in the options, as requested in #3386.

@marcelofabri
Copy link

Thanks, @philipphofmann! Can you expand a little bit more on how much of a priority this is from Sentry's point of view and what should we expect in terms of timeline? 🙏

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Nov 8, 2023
@kahest
Copy link
Member

kahest commented Nov 9, 2023

@marcelofabri We bumped the priority because we have more data points that hints would be a useful addition for some use cases. We don't plan to tackle this within the next few weeks at the moment so don't have a specific timeline, but we'd want to land this within the next months.

@sebastienboisvert
Copy link

Any updates on this? The (in)ability to add attachments to crash reports may be a deal-breaker for us.

@philipphofmann
Copy link
Member

@sebastienboisvert, no sadly no updates yet. What is your use case for adding attachments to crash reports? Maybe there is already a working solution covering your use case.

@sebastienboisvert
Copy link

@philipphofmann as mentioned in some of the linked issues, we'd like to include text logs as an attachment as part of the crash report.

As an alternative I'm looking to see if there's a way to upload an attachment separately through the REST API (still reading through the docs).

@philipphofmann
Copy link
Member

@sebastienboisvert, if your text logs aren't huge, you could consider adding breadcrumbs in before the SDK sends the crash event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: Todo
Development

No branches or pull requests

6 participants