Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would like to add switches to make attachScreenshot and attachViewHierarchy applicable to user feedback. #2962

Closed
rakuyoMo opened this issue Apr 26, 2023 · 3 comments

Comments

@rakuyoMo
Copy link

rakuyoMo commented Apr 26, 2023

Problem Statement

In the current version, if you want to use the attachScreenshot and attachViewHierarchy properties while reporting user feedback, you can only do it via capture(error:) (I can change the level to info)

However, reporting user feedback via the capture(message:) method should be a better option.

I would like attachScreenshot and attachViewHierarchy to work for user feedback.

Solution Brainstorm

Or we could add an attribute, e.g. "alwaysCarryAttachments", to give the user the choice of whether to upload attachments or not.

Only very minor changes to SentryScreenshotIntegration and SentryViewHierarchyIntegration are required. Other platforms should be similar.

Are you willing to submit a PR?

Yes, but only for iOS and Android platforms.

@brustolin
Copy link
Contributor

I think the easier solution would be to have a property in SentryEvent to indicate the need of capturing the screen, and then it would be possible to use SentrySDK.captureEvent

Thanks for opening this. We will discuss it and get back to you.

@rakuyoMo
Copy link
Author

I think the easier solution would be to have a property in SentryEvent to indicate the need of capturing the screen, and then it would be possible to use SentrySDK.captureEvent

Thanks for opening this. We will discuss it and get back to you.

Yes, we can add the property to the SentryEvent object and it feels better to do so.

@philipphofmann
Copy link
Member

@rakuyoMo, this issue will be solved once we finish #3007. We can't give you an ETA for it, but we will close this issue here to avoid duplication.

@philipphofmann philipphofmann closed this as not planned Won't fix, can't repro, duplicate, stale May 8, 2023
@github-project-automation github-project-automation bot moved this from Needs Discussion to Done in Mobile & Cross Platform SDK May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants