[SentryTransactionContext getThreadInfo] causes EXC_BAD_ACCESS - getThreadInfo attempted to dereference null pointer
#3354
Comments
github-project-automation
bot
moved this to Needs Discussion
in Mobile & Cross Platform SDK
|
Across 65 devices we saw this crash only on single Intel based MacBook. |
|
More information from the crash log: |
kahest
moved this from Needs Discussion
to Needs Investigation
in Mobile & Cross Platform SDK
|
Thanks for reporting @jozefizso, we'll investigate. (Internal reference.) |
|
@jozefizso Are these macs that are under your control and could be used to test a patch? We have a potential workaround in #3364. |
|
@armcknight We can contact the customer from our private beta program and try to have UX call to test it out. |
|
This happened to our private beta customer. We will try to contact them to test the fix. |
github-project-automation
bot
moved this from Needs Review
to Done
in Mobile & Cross Platform SDK
|
We've merged the PR, I'll ping back here when we generate the next release with the patch. |
|
Thanks a lot @armcknight. 🎆 |
|
The fix was released with 8.15.0. |
|
We had a UX call with a customer who had crash with Sentry v8.9.4. System info: Stacktrace: Crashlog info: |
|
@jozefizso, as pointed out above, this should be fixed with 8.15.0. |
|
@jozefizso are you able to validate the branch in the linked pull request (#3443)? |
|
Hi @armcknight, we have another test MacBook available where our app crashes with the 8.15.2. I compiled our app with the #3443 as SPM reference and still got the crash: https://github.com/getsentry/sentry-cocoa/blob/armcknight/fix/3354-nilcheck/Sources/Sentry/SentryTransactionContext.mm#L130 Model: Crash info: |
|
I tried it on the same system but on macOS 12 partition and sentry works there. |
|
Thanks for responding @jozefizso , we're investigating further. |
|
Hi, is there an update about this issue? Our app is currently unusable on macOS 11 because of this. |
|
We don't currently have another lead on this, we're planning to take another look at it next week. Sorry for the delay! Are you able to describe what's going on in your repro case at the time this crashes, if there's something reliably reproducing it? Are you using other threads, or creating/destroying many? Are you starting/stopping a manual transaction from main/other thread, or is this from automatic instrumentation? |
|
When I compile the app and sentry-cocoa with disabled optimizations, I get this stack trace: The app will call We will create content view and show it in a new Roughly: @main
final class AppDelegate: NSObject, NSApplicationDelegate {
func applicationDidFinishLaunching(_ aNotification: Notification) {
SentrySDK.start { options in options.dsn = "DSN" }
// create content view and NSWindow...
self.appFlow = PreInstallFlow(
appState: self.appState,
buildInfo: buildInfo
)
Task { @MainActor in
await self.appFlow?.start()
}
}
}
struct PreInstallFlow: AppFlow {
func start() async {
SentrySDK.startTransaction(
name: "PreInstallFlow",
operation: #function,
bindToScope: true
)
}
} |
|
When I changed the code and put the |
|
Thanks for the additional information @jozefizso . I'm not sure it's actually because of async/await and actors, but good to know more ways to look at this. |
|
@armcknight I can't find instances of this in our internal monitoring (last 90 days) anymore, but I see the PR has never been merged. Do you suggest we get it merged? |
|
@kahest Our user base on macOS 11 dropped and we stopped supporting this OS. We have customers which run our product and do not report crashes - yet we would advise them to upgrade OS first if they had issues. |
|
thank you @jozefizso for the speedy reply! I'll close this, but feel free to comment here with reports if it pops up again |
github-project-automation
bot
moved this from Needs Investigation
to Done
in Mobile & Cross Platform SDK
Platform
macOS
Operating system: macOS 11.7.8(20G1351)
Model: MacBookPro11,3 (Intel)
Installed
Swift Package Manager
Version
8.9.4
Steps to Reproduce
SentrySDK.startTransaction()(on main thread)EXC_BAD_ACCESS - getThreadInfo > attempted to dereference null pointerExpected Result
Application should not crash.
Actual Result
Are you willing to submit a PR?
No response
The text was updated successfully, but these errors were encountered: