Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sample rate naming for iOS Replay #4213

Closed
Tracked by #74441
jas-kas opened this issue Jul 31, 2024 · 2 comments · Fixed by #4218
Closed
Tracked by #74441

Update sample rate naming for iOS Replay #4213

jas-kas opened this issue Jul 31, 2024 · 2 comments · Fixed by #4218
Assignees
@brustolin

Comments

@jas-kas
Copy link
Member

jas-kas commented Jul 31, 2024 •
edited
Loading

options.experimental.sessionReplay.errorSampleRate = 1.0 --> options.experimental.sessionReplay.onErrorSampleRate = 1.0
@jas-kas jas-kas mentioned this issue Jul 31, 2024
Closed
@jas-kas jas-kas transferred this issue from getsentry/sentry Jul 31, 2024
@jas-kas jas-kas moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Jul 31, 2024
@brustolin brustolin mentioned this issue Aug 1, 2024
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from Backlog to Done in Mobile & Cross Platform SDK Aug 1, 2024
@jas-kas
Copy link
Member Author

jas-kas commented Aug 1, 2024

lets update our docs too? :D https://docs.sentry.io/platforms/apple/guides/ios/session-replay/

@brustolin
Copy link
Contributor

lets update our docs too? :D https://docs.sentry.io/platforms/apple/guides/ios/session-replay/

Yes!! : getsentry/sentry-docs#10946
But we need to make a release before merging the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brustolin brustolin

Labels
None yet
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Rename session replay errorSampleRate property to onErrorSampleRate getsentry/sentry-cocoa
2 participants
@brustolin @jas-kas