Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sample_rand to non-nullable values #4830

Open
1 task
philprime opened this issue Feb 11, 2025 · 0 comments
Open
1 task

Change sample_rand to non-nullable values #4830

philprime opened this issue Feb 11, 2025 · 0 comments
Assignees

Comments

@philprime
Copy link
Contributor

philprime commented Feb 11, 2025

Description

Our current implementation uses nullable values for sentry_rand in the SentryBaggage.
This allows cases where the values are null and not set in the baggage.

There is an ongoing clarification effort happening in getsentry/sentry-docs#12592 to clarify that these values must be set, therefore we should change the types and refactor the code base to adhere to compiler errors.

🛑 Blocked by

Preview Give feedback
@philprime philprime self-assigned this Feb 11, 2025
@kahest kahest moved this from Needs Discussion to Blocked in Mobile & Cross Platform SDK Feb 12, 2025
@philprime philprime changed the title Change sample_rate and sample_rand to non-nullable values Change sample_rand to non-nullable values Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Blocked
Development

No branches or pull requests

1 participant