Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disk space as optional context #4850

Open
diogot opened this issue Feb 14, 2025 · 4 comments
Open

Add disk space as optional context #4850

diogot opened this issue Feb 14, 2025 · 4 comments

Comments

@diogot
Copy link

diogot commented Feb 14, 2025

Problem Statement

In the past the SDK seems to add the disk space to the device info in events, but it was removed.
I see that this info isn't necessary for most of the apps, but our app requires a relevant of disk space to download videos, and we have error that is important to know the available disk space to help identify the root cause of the problem.

Solution Brainstorm

Given that this info isn't necessary to all apps I suggest to make it opt in.

Are you willing to submit a PR?

No response

@philipphofmann
Copy link
Member

We still need to investigate if we can provide that info per default. In the meantime, @diogot you can consider adding this info manually via the context.

@diogot
Copy link
Author

diogot commented Feb 17, 2025

I was reading the allowed reasons to access in NSPrivacyAccessedAPICategoryDiskSpace and it seems that there isn't any reason that supports that. I.e. using storage and free storage memory for automated bug report.
We're looking in the alternative way to use the reason 7D9E.1.

Thanks for the context idea.

@philipphofmann
Copy link
Member

OK, I just checked the reasons. We could only use 7D9E.1, but we must ask the user for permission first. We could only integrate this now into our user feedback feature.

@armcknight, it could be useful to attach the disk space after asking for permission in the user feedback feature. But as this will only be helpful for a minor portion of our users, it could take some time until we implement this @diogot.

@diogot
Copy link
Author

diogot commented Feb 17, 2025

No need to rush, when I opened the issue I didn't realized the complexity behind this.

Thanks!

@philprime philprime moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants