Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading Session Replay When it should not? #4866

Open
acfriedman opened this issue Feb 18, 2025 · 3 comments
Open

Uploading Session Replay When it should not? #4866

acfriedman opened this issue Feb 18, 2025 · 3 comments

Comments

@acfriedman
Copy link

Platform

iOS

Environment

Production

Installed

Swift Package Manager

Version

8.44.0

Xcode Version

16.2

Did it work on previous versions?

No response

Steps to Reproduce

My session replay configuration is set like:

        options.sessionReplay.sessionSampleRate = 0.0
        options.sessionReplay.onErrorSampleRate = 0.5

Expected Result

Should not upload a full session replay to Sentry

Actual Result

I am seeing a full session replay uploaded to Sentry web WITHOUT an error.

Image

Are you willing to submit a PR?

No response

@philprime
Copy link
Contributor

philprime commented Feb 19, 2025

Hi @acfriedman, thanks for reporting this issue.

Can you please provide your full Sentry configuration block (or ideally a reproducible project), so I can try to reproduce it in our sample projects?

Furthermore, are you using SentrySDK.replay.start() in your application?

@acfriedman
Copy link
Author

acfriedman commented Feb 19, 2025

Hi @philprime

I spoke with "Billy" about this in Discord, and he said that this specific issue that I was seeing was a result of the error being filtered out due to rate limiting. Which makes sense to me. Our project has a very low rate limit at the moment.

However, Billy also said:

I'm also seeing other oddities with that replay that we will look into (e.g. most of that replay is "unavailable" which looks wrong)

I'd also like to suggest a feature enhancement, that is, our app has very long sessions, and its very unlikely that most of these sessions will require the full recording after an error. If we could set a max duration on the replay that would be nice. I'm not sure how much an hour+ video impacts performance, but even if its still negligible the UX doesn't seem great either way.

Furthermore, are you using SentrySDK.replay.start() in your application?

We are not

Also, I am no longer seeing this particular replay in the sentry Web view.. looks like it was potentially deleted

@billyvg
Copy link
Member

billyvg commented Feb 19, 2025

@acfriedman hey, Billy here -- we took another look at it, and some details in the replay suggest it may not be due to rate limiting (the replayType says it's session), so we're continuing investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Investigation
Development

No branches or pull requests

3 participants