Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect file used in plugin.xml #363

Open
expcapitaldev opened this issue Nov 18, 2024 · 7 comments · May be fixed by #371
Open

Incorrect file used in plugin.xml #363

expcapitaldev opened this issue Nov 18, 2024 · 7 comments · May be fixed by #371
Assignees
@lucas-zimerman
Labels
Platform: Cordova

Comments

@expcapitaldev
Copy link

expcapitaldev commented Nov 18, 2024 •
edited
Loading

In the plugin.xml file for Sentry Cordova, the wrong JavaScript files are referenced. Currently, the unminified files are being used:

    <js-module src="dist/js/sentry-cordova.bundle.js" name="Sentry">
        <clobbers target="Sentry" />
    </js-module>
    <asset src="dist/js/sentry-cordova.bundle.js.map" target="plugins/sentry-cordova/dist/js/sentry-cordova.bundle.js.map" />

However, the minified files should be used instead to reduce file size and improve performance. The correct references should be:

<js-module src="dist/js/sentry-cordova.bundle.min.js" name="Sentry">
    <clobbers target="Sentry" />
</js-module>
<asset src="dist/js/sentry-cordova.bundle.min.js.map" target="plugins/sentry-cordova/dist/js/sentry-cordova.bundle.min.js.map" />

The minified files are already present in the bundle but are not being referenced correctly.

Expected Behavior:
Replace the references in plugin.xml to use the minified .min.js files and their corresponding .min.js.map files.

Steps to Reproduce:

Check the plugin.xml in the Sentry Cordova plugin.
Note that the unminified files are referenced instead of the minified versions.
Impact:
Using unminified files increases the file size unnecessarily and can slow down the application.

Proposed Fix:
Update plugin.xml to reference the minified files.
@lucas-zimerman lucas-zimerman moved this from Needs Discussion to Todo in Mobile & Cross Platform SDK Nov 18, 2024
@lucas-zimerman
Copy link
Collaborator

Hi and thank you for spotting this!
Would you like to open a PR to fix it?

@expcapitaldev
Copy link
Author

Thank you for the quick response!
I’d prefer if your team could handle this directly, as it’s a core issue in the plugin.

@lucas-zimerman
Copy link
Collaborator

Sure thing, we will work on it, thank you for your response!

@github-actions GitHub Actions
Copy link

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@expcapitaldev
Copy link
Author

issue is still relevant.
can you provide ETA?

@expcapitaldev
Copy link
Author

hi Sentry team ,any updates here ?

@lucas-zimerman
Copy link
Collaborator

Sorry, it's harder to keep track of closed issues, I will work on this briefly but it may take a while ( a week or two) since the code reviewer will take some days off

@lucas-zimerman lucas-zimerman moved this from Done to In Progress in Mobile & Cross Platform SDK Feb 26, 2025
@lucas-zimerman lucas-zimerman linked a pull request Feb 27, 2025 that will close this issue
Open
@lucas-zimerman lucas-zimerman moved this from In Progress to Needs Review in Mobile & Cross Platform SDK Feb 27, 2025
@lucas-zimerman lucas-zimerman self-assigned this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucas-zimerman lucas-zimerman

Labels
Platform: Cordova
Projects
Mobile & Cross Platform SDK
Status: Needs Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Use minified bundle getsentry/sentry-cordova
2 participants
@lucas-zimerman @expcapitaldev