Sentry Dart Plugin - GA - plan

[marandaneto]

• Tests/Integration tests and test: make plugin unit-testable #52
• Publish via Craft/Publish (there's a bug)
• Documentation on sentry.io/docs and Wizard
• Support --dart-define (nice to have)
• Support set-commits (nice to have) - feat: support release commits (and improve tests) #62
• Support sentry.properties (nice to have)

[vaind]

The plugin currently uses current directory as the base for upload-dif. I think this should be changed to build, even despite the reason given in the comment (that users can export debug symbols to a different dir). I think so because currently all binaries from the dart build directory (.dart_tool) are uploaded. In normal apps, there may be a lot of unnecessary stuff and tools. As an example - here's a list of uploaded files from the e integraton-test app - e.g. sentry-cli & those .bin files shouldn't be uploaded at all.

  CMakeDetermineCompilerABI_C.bin: count=8 chunks=8
  CMakeDetermineCompilerABI_CXX.bin: count=8 chunks=8
  libapp.so: count=6 chunks=6
  libflutter.so: count=6 chunks=10
  libhello_santry.so: count=12 chunks=12
  libhello_santry.so.sym: count=4 chunks=4
  sentry-cli.exe: count=1 chunks=2

Similarly, if the app uses integration tests (which would build apps itself), those compiled apps would be uploaded as well.

[vaind]

Similarly, if including sources, only the lib directory should be included IMO.

[marandaneto]

there may be a lot of unnecessary stuff and tools

Yes, this is indeed a problem, but if there are crashes coming from dependencies, or Flutter itself, the symbols won't be in the build folder most likely, I guess?

The plugin currently uses current directory as the base for upload-dif. I think this should be changed to build, even despite the reason given in the comment (that users can export debug symbols to a different dir)

That will make the plugin useless by default since examples of this command already use a sibling folder of build.

[marandaneto]

Closing it since each item of the checklist has its own issue.