Skip to content

Commit a2fda2c

Browse files
committed
Update
1 parent bfb5259 commit a2fda2c

File tree

3 files changed

+7
-28
lines changed

3 files changed

+7
-28
lines changed

packages/flutter/ios/sentry_flutter/Sources/sentry_flutter/SentryFlutterPlugin.swift

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -624,9 +624,11 @@ public class SentryFlutterPlugin: NSObject, FlutterPlugin {
624624
}
625625

626626
@objc public class func addBreadcrumbAsBytes(_ breadcrumbBytes: NSData) {
627-
guard let breadcrumbString = String(data: breadcrumbBytes as Data, encoding: .utf8),
628-
let jsonData = breadcrumbString.data(using: .utf8),
629-
let breadcrumbDict = try? JSONSerialization.jsonObject(with: jsonData) as? [String: Any] else {
627+
guard let breadcrumbDict = try? JSONSerialization.jsonObject(
628+
with: breadcrumbBytes as Data,
629+
options: []
630+
) as? [String: Any] else {
631+
print("addBreadcrumb failed in native cocoa: could not parse bytes")
630632
return
631633
}
632634
let breadcrumbInstance = PrivateSentrySDKOnly.breadcrumb(with: breadcrumbDict)

packages/flutter/lib/src/native/cocoa/sentry_native_cocoa.dart

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -203,19 +203,7 @@ class SentryNativeCocoa extends SentryNativeChannel {
203203
@override
204204
Future<void> addBreadcrumb(Breadcrumb breadcrumb) async {
205205
tryCatchSync('addBreadcrumb', () {
206-
// Normalize breadcrumb data like the method channel does
207-
final normalizedBreadcrumb = Breadcrumb(
208-
message: breadcrumb.message,
209-
category: breadcrumb.category,
210-
data: normalizeMap(breadcrumb.data),
211-
level: breadcrumb.level,
212-
type: breadcrumb.type,
213-
timestamp: breadcrumb.timestamp,
214-
// ignore: invalid_use_of_internal_member
215-
unknown: breadcrumb.unknown,
216-
);
217-
218-
final jsonString = json.encode(normalizedBreadcrumb.toJson());
206+
final jsonString = json.encode(breadcrumb.toJson());
219207
final bytes = utf8.encode(jsonString);
220208
final nsData = bytes.toNSData();
221209

packages/flutter/lib/src/native/java/sentry_native_java.dart

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -228,18 +228,7 @@ class SentryNativeJava extends SentryNativeChannel {
228228
JByteArray? breadcrumbBytes;
229229

230230
tryCatchSync('addBreadcrumb', () {
231-
final normalizedBreadcrumb = Breadcrumb(
232-
message: breadcrumb.message,
233-
category: breadcrumb.category,
234-
data: normalizeMap(breadcrumb.data),
235-
level: breadcrumb.level,
236-
type: breadcrumb.type,
237-
timestamp: breadcrumb.timestamp,
238-
// ignore: invalid_use_of_internal_member
239-
unknown: breadcrumb.unknown,
240-
);
241-
242-
final jsonString = json.encode(normalizedBreadcrumb.toJson());
231+
final jsonString = json.encode(breadcrumb.toJson());
243232
final bytes = utf8.encode(jsonString);
244233
breadcrumbBytes = JByteArray.from(bytes);
245234

0 commit comments

Comments
 (0)