Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SDK name of Sentry Native for Flutter #1333

Closed
Tracked by #48
marandaneto opened this issue Mar 15, 2023 · 4 comments · Fixed by #1468
Closed
Tracked by #48

Change SDK name of Sentry Native for Flutter #1333

marandaneto opened this issue Mar 15, 2023 · 4 comments · Fixed by #1468

Comments

@marandaneto
Copy link
Contributor

Description

Right now it is sentry.native.android and this is set at compile time.
Ideally, this would be sentry.native.android.flutter or just sentry.native.flutter.

@vaind
Copy link
Collaborator

vaind commented Mar 19, 2023

  1. The right name would be sentry.native.android.flutter from what I remember doing this in Unity, see https://github.com/getsentry/sentry-unity/blob/8420c95a3def1d6b611f031070d6977f3e574397/Directory.Build.targets#L190
  2. Unless there has been new development in changing this in sentry-native, it must be changed at compile time which means we cannot set it for Flutter specifically without building the android SDK. Currently, the flutter plugin just depends on package published by sentry-java https://github.com/getsentry/sentry-unity/blob/8420c95a3def1d6b611f031070d6977f3e574397/Directory.Build.targets#L190

@marandaneto
Copy link
Contributor Author

Created getsentry/sentry-native#821
Since sentry-native is transitioning from one team (former Native team) to the Mobile team (the one I work for), let me check what we can do.

@marandaneto
Copy link
Contributor Author

getsentry/sentry-native#821 is merged, now the Android SDK has to offer a public API or append .android automatically.

@marandaneto marandaneto moved this from Blocked to Backlog in Mobile & Cross Platform SDK May 16, 2023
@marandaneto
Copy link
Contributor Author

Now its possible to set the sentry-native SDK name at runtime getsentry/sentry-java#2704
This is the last missing bit.

@marandaneto marandaneto added this to the 7.x milestone May 16, 2023
@denrase denrase moved this from Backlog to In Progress in Mobile & Cross Platform SDK May 22, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Mobile & Cross Platform SDK May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants