Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align http span data to convention #1422

Closed
stefanosiano opened this issue May 5, 2023 · 2 comments · Fixed by #1477
Closed

Align http span data to convention #1422

stefanosiano opened this issue May 5, 2023 · 2 comments · Fixed by #1477
Assignees
Milestone

Comments

@stefanosiano
Copy link
Member

Description

There are few http data keys that are different from our convention
I’m talking mainly about method and response_body_size that should be http.method and http.response_content_length in breadcrumb and http span

@marandaneto
Copy link
Contributor

@stefanosiano would you like to take this PR? so you get a filling of the SDK, PRs, code reviews, how to run tests, etc? I can guide :) it should be pretty much a ctrl c - ctrl v + fixing test.

@stefanosiano
Copy link
Member Author

yeah, sure!

@stefanosiano stefanosiano self-assigned this May 8, 2023
@kahest kahest moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK May 11, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Mobile & Cross Platform SDK May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants