SPM Support #2280

denrase · 2024-09-10T13:21:28Z

📜 Description

Migration: https://docs.flutter.dev/packages-and-plugins/swift-package-manager/for-plugin-authors#how-to-add-swift-package-manager-support-to-an-existing-flutter-plugin

Enable SPM: https://docs.flutter.dev/packages-and-plugins/swift-package-manager/for-plugin-authors#how-to-turn-on-swift-package-manager

Setup iOS project for SPM
Setup macOS project for SPM
Update plugin to import Hybrid SDK for Pods & SPM

💡 Motivation and Context

Closes #2250

💚 How did you test it?

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
I updated the docs if needed
All tests passing
No breaking changes

🔮 Next steps

Blocked by #4440

github-actions · 2024-09-10T13:22:02Z

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against a4e2e38

github-actions · 2024-09-10T13:31:13Z

Android Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	459.34 ms	506.62 ms	47.28 ms
Size	6.49 MiB	7.57 MiB	1.08 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`1a93825`	347.31 ms	424.54 ms	77.23 ms
`a510d1d`	295.63 ms	344.65 ms	49.03 ms
`a7acb24`	301.00 ms	357.38 ms	56.38 ms
`6034b0a`	406.35 ms	475.93 ms	69.59 ms
`2d74010`	400.42 ms	466.50 ms	66.08 ms
`4b5a4f6`	394.19 ms	471.81 ms	77.62 ms
`bf8d36c`	505.00 ms	563.18 ms	58.18 ms
`e82709a`	361.18 ms	423.50 ms	62.32 ms
`c732386`	316.84 ms	390.62 ms	73.78 ms
`24f71aa`	358.49 ms	455.90 ms	97.41 ms

App size

Revision	Plain	With Sentry	Diff
`1a93825`	6.27 MiB	7.20 MiB	956.36 KiB
`a510d1d`	5.94 MiB	6.96 MiB	1.02 MiB
`a7acb24`	5.94 MiB	6.95 MiB	1.01 MiB
`6034b0a`	6.34 MiB	7.29 MiB	970.36 KiB
`2d74010`	6.33 MiB	7.26 MiB	943.41 KiB
`4b5a4f6`	6.34 MiB	7.28 MiB	962.57 KiB
`bf8d36c`	6.49 MiB	7.56 MiB	1.07 MiB
`e82709a`	6.34 MiB	7.29 MiB	970.37 KiB
`c732386`	6.26 MiB	7.20 MiB	958.78 KiB
`24f71aa`	6.06 MiB	7.03 MiB	990.30 KiB

Previous results on branch: feat/spm

Startup times

Revision	Plain	With Sentry	Diff
`acc2ff0`	470.52 ms	510.29 ms	39.77 ms
`160e5a5`	460.87 ms	509.56 ms	48.69 ms
`8adbf8e`	481.79 ms	530.56 ms	48.77 ms

App size

Revision	Plain	With Sentry	Diff
`acc2ff0`	6.49 MiB	7.57 MiB	1.08 MiB
`160e5a5`	6.49 MiB	7.57 MiB	1.08 MiB
`8adbf8e`	6.49 MiB	7.55 MiB	1.07 MiB

github-actions · 2024-09-10T13:36:44Z

iOS Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1234.78 ms	1256.79 ms	22.01 ms
Size	8.38 MiB	9.75 MiB	1.37 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d4d0807`	1246.94 ms	1260.69 ms	13.75 ms
`f9d18f3`	1240.20 ms	1242.78 ms	2.57 ms
`04bd9e6`	1230.78 ms	1250.71 ms	19.94 ms
`051e97a`	1245.94 ms	1249.51 ms	3.57 ms
`b8562d0`	1249.92 ms	1267.56 ms	17.64 ms
`affcf07`	1240.61 ms	1266.49 ms	25.88 ms
`2e8b1e1`	1247.45 ms	1263.67 ms	16.22 ms
`0f067d3`	1245.71 ms	1269.59 ms	23.88 ms
`f1314d5`	1246.46 ms	1270.92 ms	24.46 ms
`e239c83`	1248.40 ms	1269.28 ms	20.89 ms

App size

Revision	Plain	With Sentry	Diff
`d4d0807`	8.33 MiB	9.64 MiB	1.31 MiB
`f9d18f3`	8.29 MiB	9.36 MiB	1.07 MiB
`04bd9e6`	8.33 MiB	9.61 MiB	1.27 MiB
`051e97a`	8.28 MiB	9.34 MiB	1.06 MiB
`b8562d0`	8.33 MiB	9.54 MiB	1.22 MiB
`affcf07`	8.38 MiB	9.70 MiB	1.33 MiB
`2e8b1e1`	8.33 MiB	9.64 MiB	1.31 MiB
`0f067d3`	8.32 MiB	9.52 MiB	1.20 MiB
`f1314d5`	8.10 MiB	9.08 MiB	1004.30 KiB
`e239c83`	8.38 MiB	9.74 MiB	1.36 MiB

Previous results on branch: feat/spm

Startup times

Revision	Plain	With Sentry	Diff
`acc2ff0`	1223.71 ms	1233.08 ms	9.37 ms
`160e5a5`	1250.08 ms	1277.88 ms	27.79 ms
`8adbf8e`	1258.88 ms	1281.85 ms	22.97 ms

App size

Revision	Plain	With Sentry	Diff
`acc2ff0`	8.38 MiB	9.75 MiB	1.37 MiB
`160e5a5`	8.38 MiB	9.75 MiB	1.37 MiB
`8adbf8e`	8.38 MiB	9.73 MiB	1.36 MiB

buenaflor · 2024-09-10T14:02:14Z

flutter/ios/sentry_flutter/Package.swift

+        .library(name: "sentry-flutter", targets: ["sentry_flutter", "sentry_flutter_swift"])
+    ],
+    dependencies: [
+      .package(url: "https://github.com/getsentry/sentry-cocoa", from: "8.36.0"),


do we need to adjust update-cocoa.sh for this?

Yeah, we also need to implmenet the version update for the SPM file!

# Conflicts: # flutter/.gitignore # flutter/ios/sentry_flutter.podspec

uses locally build Swift.framwork for sim only

github-actions · 2024-11-05T16:38:46Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

flutter/ios/Classes/SentryFlutterPluginApple.swift

codecov · 2024-11-05T16:41:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.84%. Comparing base (7c7c64f) to head (a4e2e38).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2280      +/-   ##
==========================================
+ Coverage   84.72%   84.84%   +0.12%     
==========================================
  Files         253       79     -174     
  Lines        9097     2804    -6293     
==========================================
- Hits         7707     2379    -5328     
+ Misses       1390      425     -965

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-11-06T10:10:48Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

flutter/ios/Classes/SentryFlutterPluginApple.swift

github-actions · 2024-11-06T11:29:35Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

flutter/ios/Classes/SentryFlutterPluginApple.swift

github-actions · 2024-11-06T13:34:47Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

flutter/ios/Classes/SentryFlutterPluginApple.swift

github-actions · 2024-11-06T13:41:57Z

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

flutter/ios/Classes/SentryFlutterPluginApple.swift

update folder structiure to support SPM

8adbf8e

buenaflor reviewed Sep 10, 2024

View reviewed changes

denrase added 2 commits October 1, 2024 14:15

Merge branch 'main' into feat/spm

a0de8e2

remove trailing comma

0ccc10e

denrase added the Blocked label Oct 1, 2024

denrase mentioned this pull request Oct 1, 2024

Make HybridPublic folder headers public in Sentry.framework getsentry/sentry-cocoa#4384

Closed

7 tasks

denrase added 2 commits October 1, 2024 15:12

update folder structure for mac

a2afc01

Merge branch 'main' into feat/spm

16bae70

denrase mentioned this pull request Oct 15, 2024

Expose Sentry._Hybrid explicit module getsentry/sentry-cocoa#4440

Draft

7 tasks

denrase added 3 commits November 5, 2024 11:33

Merge branch 'main' into feat/spm

0636b64

# Conflicts: # flutter/.gitignore # flutter/ios/sentry_flutter.podspec

fix spm import

9a635fa

update to import correctly (u

6034522

uses locally build Swift.framwork for sim only

move to swift as main spm package

acc2ff0

setup macOS

160e5a5

denrase added 2 commits November 6, 2024 13:58

prefix hybrid import with _

31fcd63

add cl entry, update hybrid module name

866fe0f

denrase added 2 commits November 6, 2024 14:39

add spm to guthub workflow

bb6d8ac

update Package.swift to use remote sentry-cocoa

a4e2e38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SPM Support #2280

SPM Support #2280

denrase commented Sep 10, 2024 •

edited

Loading

github-actions bot commented Sep 10, 2024 •

edited

Loading

github-actions bot commented Sep 10, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: feat/spm

Startup times

App size

github-actions bot commented Sep 10, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

Previous results on branch: feat/spm

Startup times

App size

buenaflor Sep 10, 2024

denrase Oct 1, 2024

github-actions bot commented Nov 5, 2024

codecov bot commented Nov 5, 2024 •

edited

Loading

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

SPM Support #2280

Are you sure you want to change the base?

SPM Support #2280

Conversation

denrase commented Sep 10, 2024 • edited Loading

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Sep 10, 2024 • edited Loading

github-actions bot commented Sep 10, 2024 • edited Loading

Android Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: feat/spm

Startup times

App size

github-actions bot commented Sep 10, 2024 • edited Loading

iOS Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: feat/spm

Startup times

App size

buenaflor Sep 10, 2024

Choose a reason for hiding this comment

denrase Oct 1, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 5, 2024

🚨 Detected changes in high risk code 🚨

codecov bot commented Nov 5, 2024 • edited Loading

Codecov Report

github-actions bot commented Nov 6, 2024

🚨 Detected changes in high risk code 🚨

github-actions bot commented Nov 6, 2024

🚨 Detected changes in high risk code 🚨

github-actions bot commented Nov 6, 2024

🚨 Detected changes in high risk code 🚨

github-actions bot commented Nov 6, 2024

🚨 Detected changes in high risk code 🚨

denrase commented Sep 10, 2024 •

edited

Loading

github-actions bot commented Sep 10, 2024 •

edited

Loading

github-actions bot commented Sep 10, 2024 •

edited

Loading

github-actions bot commented Sep 10, 2024 •

edited

Loading

codecov bot commented Nov 5, 2024 •

edited

Loading