-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPM Support #2280
base: main
Are you sure you want to change the base?
SPM Support #2280
Conversation
|
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e5b744f | 302.70 ms | 342.17 ms | 39.47 ms |
0ac1eed | 370.60 ms | 441.54 ms | 70.94 ms |
90a08ea | 477.25 ms | 534.10 ms | 56.85 ms |
0db91cc | 327.85 ms | 387.31 ms | 59.46 ms |
061fed2 | 434.11 ms | 506.49 ms | 72.38 ms |
4829ad3 | 381.55 ms | 455.45 ms | 73.90 ms |
519423f | 357.00 ms | 415.77 ms | 58.77 ms |
ddc97ad | 331.45 ms | 384.06 ms | 52.61 ms |
e3ef570 | 389.71 ms | 459.16 ms | 69.45 ms |
2d3b03d | 309.53 ms | 353.40 ms | 43.87 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e5b744f | 6.06 MiB | 7.09 MiB | 1.03 MiB |
0ac1eed | 6.06 MiB | 7.03 MiB | 990.44 KiB |
90a08ea | 6.49 MiB | 7.55 MiB | 1.06 MiB |
0db91cc | 5.94 MiB | 6.95 MiB | 1.01 MiB |
061fed2 | 6.52 MiB | 7.59 MiB | 1.06 MiB |
4829ad3 | 6.33 MiB | 7.26 MiB | 943.11 KiB |
519423f | 6.06 MiB | 7.03 MiB | 989.24 KiB |
ddc97ad | 6.16 MiB | 7.14 MiB | 1003.75 KiB |
e3ef570 | 6.33 MiB | 7.26 MiB | 950.38 KiB |
2d3b03d | 6.06 MiB | 7.09 MiB | 1.03 MiB |
Previous results on branch: feat/spm
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a4e2e38 | 459.34 ms | 506.62 ms | 47.28 ms |
160e5a5 | 460.87 ms | 509.56 ms | 48.69 ms |
8adbf8e | 481.79 ms | 530.56 ms | 48.77 ms |
acc2ff0 | 470.52 ms | 510.29 ms | 39.77 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a4e2e38 | 6.49 MiB | 7.57 MiB | 1.08 MiB |
160e5a5 | 6.49 MiB | 7.57 MiB | 1.08 MiB |
8adbf8e | 6.49 MiB | 7.55 MiB | 1.07 MiB |
acc2ff0 | 6.49 MiB | 7.57 MiB | 1.08 MiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d4d0807 | 1246.94 ms | 1260.69 ms | 13.75 ms |
f9d18f3 | 1240.20 ms | 1242.78 ms | 2.57 ms |
04bd9e6 | 1230.78 ms | 1250.71 ms | 19.94 ms |
051e97a | 1245.94 ms | 1249.51 ms | 3.57 ms |
b8562d0 | 1249.92 ms | 1267.56 ms | 17.64 ms |
affcf07 | 1240.61 ms | 1266.49 ms | 25.88 ms |
2e8b1e1 | 1247.45 ms | 1263.67 ms | 16.22 ms |
0f067d3 | 1245.71 ms | 1269.59 ms | 23.88 ms |
f1314d5 | 1246.46 ms | 1270.92 ms | 24.46 ms |
e239c83 | 1248.40 ms | 1269.28 ms | 20.89 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d4d0807 | 8.33 MiB | 9.64 MiB | 1.31 MiB |
f9d18f3 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
04bd9e6 | 8.33 MiB | 9.61 MiB | 1.27 MiB |
051e97a | 8.28 MiB | 9.34 MiB | 1.06 MiB |
b8562d0 | 8.33 MiB | 9.54 MiB | 1.22 MiB |
affcf07 | 8.38 MiB | 9.70 MiB | 1.33 MiB |
2e8b1e1 | 8.33 MiB | 9.64 MiB | 1.31 MiB |
0f067d3 | 8.32 MiB | 9.52 MiB | 1.20 MiB |
f1314d5 | 8.10 MiB | 9.08 MiB | 1004.30 KiB |
e239c83 | 8.38 MiB | 9.74 MiB | 1.36 MiB |
Previous results on branch: feat/spm
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
acc2ff0 | 1223.71 ms | 1233.08 ms | 9.37 ms |
160e5a5 | 1250.08 ms | 1277.88 ms | 27.79 ms |
8adbf8e | 1258.88 ms | 1281.85 ms | 22.97 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
acc2ff0 | 8.38 MiB | 9.75 MiB | 1.37 MiB |
160e5a5 | 8.38 MiB | 9.75 MiB | 1.37 MiB |
8adbf8e | 8.38 MiB | 9.73 MiB | 1.36 MiB |
.library(name: "sentry-flutter", targets: ["sentry_flutter", "sentry_flutter_swift"]) | ||
], | ||
dependencies: [ | ||
.package(url: "https://github.com/getsentry/sentry-cocoa", from: "8.36.0"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to adjust update-cocoa.sh
for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we also need to implmenet the version update for the SPM file!
# Conflicts: # flutter/.gitignore # flutter/ios/sentry_flutter.podspec
uses locally build Swift.framwork for sim only
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2280 +/- ##
==========================================
+ Coverage 85.02% 85.88% +0.86%
==========================================
Files 257 81 -176
Lines 9175 2863 -6312
==========================================
- Hits 7801 2459 -5342
+ Misses 1374 404 -970 ☔ View full report in Codecov by Sentry. |
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
# Conflicts: # flutter/ios/sentry_flutter.podspec
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
@@ -93,6 +93,8 @@ | |||
); | |||
``` | |||
|
|||
- SPM Support ([#2280](https://github.com/getsentry/sentry-dart/pull/2280)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 🚫 The changelog entry seems to be part of an already released section
## 8.10.1
.
Consider moving the entry to the## Unreleased
section, please.
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
📜 Description
Migration: https://docs.flutter.dev/packages-and-plugins/swift-package-manager/for-plugin-authors#how-to-add-swift-package-manager-support-to-an-existing-flutter-plugin
Enable SPM: https://docs.flutter.dev/packages-and-plugins/swift-package-manager/for-plugin-authors#how-to-turn-on-swift-package-manager
💡 Motivation and Context
Closes #2250
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps