Emit transaction.data in contexts.trace.data
#2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buenaflor
requested review from
krystofwoldrich and
stefanosiano
as code owners
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2284 +/- ##
==========================================
- Coverage 88.11% 88.11% -0.01%
==========================================
Files 247 247
Lines 8591 8596 +5
==========================================
+ Hits 7570 7574 +4
- Misses 1021 1022 +1 ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2d4fd8b | 376.67 ms | 456.88 ms | 80.21 ms |
| 3e33891 | 313.60 ms | 379.51 ms | 65.91 ms |
| 1cdcacf | 389.94 ms | 463.53 ms | 73.59 ms |
| 31b2afb | 397.04 ms | 475.09 ms | 78.04 ms |
| 3e9fb0e | 329.14 ms | 359.16 ms | 30.02 ms |
| 211a7aa | 324.19 ms | 393.26 ms | 69.07 ms |
| a094100 | 388.02 ms | 459.50 ms | 71.48 ms |
| 6d317ea | 303.46 ms | 356.06 ms | 52.60 ms |
| 9555112 | 448.81 ms | 488.89 ms | 40.08 ms |
| 5d2b46d | 307.74 ms | 349.85 ms | 42.11 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2d4fd8b | 6.27 MiB | 7.20 MiB | 958.59 KiB |
| 3e33891 | 6.16 MiB | 7.14 MiB | 1007.46 KiB |
| 1cdcacf | 6.33 MiB | 7.26 MiB | 949.77 KiB |
| 31b2afb | 6.34 MiB | 7.28 MiB | 966.36 KiB |
| 3e9fb0e | 5.94 MiB | 6.95 MiB | 1.01 MiB |
| 211a7aa | 6.06 MiB | 7.03 MiB | 997.24 KiB |
| a094100 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
| 6d317ea | 5.94 MiB | 6.92 MiB | 1001.74 KiB |
| 9555112 | 6.52 MiB | 7.59 MiB | 1.06 MiB |
| 5d2b46d | 6.16 MiB | 7.13 MiB | 1000.82 KiB |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| cdf7172 | 1264.43 ms | 1291.39 ms | 26.96 ms |
| d0312c9 | 1205.55 ms | 1224.45 ms | 18.90 ms |
| deaeece | 1252.82 ms | 1279.04 ms | 26.22 ms |
| 84bc635 | 1252.26 ms | 1273.96 ms | 21.70 ms |
| b44db8f | 1255.29 ms | 1258.90 ms | 3.61 ms |
| ecb4003 | 1266.94 ms | 1290.24 ms | 23.31 ms |
| 88e4bfd | 1236.44 ms | 1256.33 ms | 19.90 ms |
| cfa25fc | 1251.77 ms | 1275.69 ms | 23.92 ms |
| abcdba3 | 1257.31 ms | 1283.49 ms | 26.18 ms |
| 43760f9 | 1216.07 ms | 1238.51 ms | 22.44 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| cdf7172 | 8.16 MiB | 9.16 MiB | 1.01 MiB |
| d0312c9 | 8.32 MiB | 9.39 MiB | 1.06 MiB |
| deaeece | 8.16 MiB | 9.17 MiB | 1.01 MiB |
| 84bc635 | 8.33 MiB | 9.40 MiB | 1.07 MiB |
| b44db8f | 8.29 MiB | 9.37 MiB | 1.08 MiB |
| ecb4003 | 8.09 MiB | 9.07 MiB | 1000.82 KiB |
| 88e4bfd | 8.33 MiB | 9.64 MiB | 1.31 MiB |
| cfa25fc | 8.32 MiB | 9.43 MiB | 1.10 MiB |
| abcdba3 | 8.15 MiB | 9.12 MiB | 989.76 KiB |
| 43760f9 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
buenaflor
deleted the
feat/emit-transaction-data-in-trace-context-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Adds the transaction data to contexts.trace as well.
💡 Motivation and Context
As preparation for extracting metrics from transaction data.
Closes #2257
💚 How did you test it?
Unit test, spotlight
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps