Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for isar community fork for sentry_isar package #2296

Closed
sbordeyne opened this issue Sep 18, 2024 · 2 comments
Closed

Add support for isar community fork for sentry_isar package #2296

sbordeyne opened this issue Sep 18, 2024 · 2 comments

Comments

@sbordeyne
Copy link

Problem Statement

The main isar package seems to have gone unmaintained, thankfully the community has picked up the slack and supports it through https://github.com/isar-community/isar.

The problem is that even though there seems to be 100% compatibility with the main isar package, sentry's isar integration depends on isar, which causes problems : the community fork is not hosted on pub.dev hence pub flags it as incompatible

Solution Brainstorm

I think the only way to actually support it is to add a new package : sentry_isar_community which doesn't depend on isar, but instead on the forked version. The code can remain the same, except for the generated code which needs to be regenerated to fit the changes and bug fixes in the community fork.

Are you willing to submit a PR?

Yes

@ueman
Copy link
Collaborator

ueman commented Sep 18, 2024

Why doesn't the community supports the Sentry integration?

@kahest
Copy link
Member

kahest commented Sep 23, 2024

As discussed here, there is currently no need for a separate package. Closing this for now, feel free to follow up here if there's problems or questions

@kahest kahest closed this as not planned Won't fix, can't repro, duplicate, stale Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

No branches or pull requests

3 participants