Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI complains about Flutter valid archies #348

Closed
marandaneto opened this issue Mar 11, 2021 · 8 comments · Fixed by #438
Closed

CI complains about Flutter valid archies #348

marandaneto opened this issue Mar 11, 2021 · 8 comments · Fixed by #438

Comments

@marandaneto
Copy link
Contributor

Context #345 (comment)

@marandaneto marandaneto added the CI label Mar 11, 2021
@marandaneto
Copy link
Contributor Author

@denrase just reading your comment, tbh I'm not sure what to do either, we need to be able to run on the simulator, that's for sure.

@marandaneto
Copy link
Contributor Author

when I run the pod lint locally, it works sentry_flutter passed validation., Flutter v2.0.1

@marandaneto marandaneto mentioned this issue Mar 11, 2021
5 tasks
@denrase
Copy link
Collaborator

denrase commented Mar 11, 2021

I also ran it locally and it failed for me. Flutter 2.0.1 and Dart 2.12.0.

@marandaneto
Copy link
Contributor Author

@denrase maybe you could have a look at it then, cus I can't reproduce it, I've opened a PR to test it out on CI but it didn't help :(

@denrase
Copy link
Collaborator

denrase commented Mar 12, 2021

@marandaneto

No luck so far, still get the error when building with 'VALID_ARCHS[sdk=iphonesimulator*]' => 'x86_64', as the Flutter.xcframework contains ios-x86_64-simulator ios-armv7_arm64 slices, and somehow the matching between them fails. When i change the iphonesimulator valid archs to ios-x86_64-simulator, pod lint is successful, but I still have warnings:

 -> sentry_flutter (0.0.1)
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | xcodebuild:  note: Building targets in parallel
    - NOTE  | xcodebuild:  note: Using codesigning identity override: -
    - NOTE  | [iOS] xcodebuild:  note: Planning build
    - NOTE  | [iOS] xcodebuild:  note: Constructing build description
    - NOTE  | [iOS] xcodebuild:  warning: None of the architectures in ARCHS (arm64, x86_64, i386) are valid. Consider setting ARCHS to $(ARCHS_STANDARD) or updating it to include at least one value from VALID_ARCHS (ios-x86_64-simulator). (in target 'sentry_flutter' from project 'Pods')
    - NOTE  | [iOS] xcodebuild:  warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.4.99. (in target 'Flutter' from project 'Pods')
    - NOTE  | [iOS] xcodebuild:  warning: [CP] Unable to find matching .xcframework slice in 'Flutter/Flutter.xcframework Flutter framework ios-x86_64-simulator ios-armv7_arm64' for the current build architectures (arm64 x86_64 i386).

Also checked out #349, it's the same either way.

Somewhere the matching between x86_64 and ios-x86_64-simulator seems to fail. And Flutter versions below 2 seem to have the slices for arm64 x86_64 i386 in the Flutter.xcframework, as the last warning is not displayed when setting the Flutter version to 1.22.4 in the podspec.

@marandaneto
Copy link
Contributor Author

I see, well, I don't know what to do either, nothing about that (flutter repo)?

@marandaneto
Copy link
Contributor Author

I commented out for now 82ef2ab
as it does change the functionality of the SDK anyway.

@ueman
Copy link
Collaborator

ueman commented Apr 27, 2021

We should also add linting for the macOS podspec file.

@ueman ueman mentioned this issue Apr 27, 2021
5 tasks
@ueman ueman self-assigned this Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants