Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifiy user of invalid trace rate setting #981

Closed
ueman opened this issue Aug 13, 2022 · 2 comments · Fixed by #1701
Closed

Notifiy user of invalid trace rate setting #981

ueman opened this issue Aug 13, 2022 · 2 comments · Fixed by #1701
Assignees
@buenaflor
Labels
docs enhancement Platform: Dart

Comments

@ueman
Copy link
Collaborator

ueman commented Aug 13, 2022

Performance tracing doesn't work if both the tracesSampler and the traceSampler rate is set. There should be some sort of error when the user does it.

This enlightenment come out of a recent discussion on Discord.
@bruno-garcia bruno-garcia moved this to Needs Discussion in Mobile & Cross Platform SDK Aug 15, 2022
@marandaneto
Copy link
Contributor

The docs states // OR but yeah it could be improved, an extra log on the SDK side might help.

@marandaneto marandaneto moved this to Needs Discussion in Mobile & Cross Platform SDK May 23, 2023
@marandaneto marandaneto moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK May 25, 2023
@marandaneto
Copy link
Contributor

marandaneto commented May 25, 2023 •
edited
Loading

Align that between SDKs, should we just log in to the console if the traces rate is out of the range or if both are set and they should not? will follow up later.
JS documents which one has precedence in case both are set.
Android throws if its out of range, if you set both, sampler callback has precedence over the other one, JS is the same.

@marandaneto marandaneto modified the milestone: 7.x May 25, 2023
@buenaflor buenaflor self-assigned this Sep 12, 2023
@buenaflor buenaflor moved this from Backlog to Todo in Mobile & Cross Platform SDK Oct 23, 2023
@buenaflor buenaflor moved this from Todo to In Progress in Mobile & Cross Platform SDK Oct 24, 2023
@buenaflor buenaflor mentioned this issue Oct 25, 2023
Merged
6 tasks
@buenaflor buenaflor moved this from In Progress to Needs Review in Mobile & Cross Platform SDK Oct 25, 2023
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Mobile & Cross Platform SDK Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@buenaflor buenaflor

Labels
docs enhancement Platform: Dart
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: log warning if both tracesSampleRate and tracesSampler are set getsentry/sentry-dart
4 participants
@ueman @kahest @marandaneto @buenaflor