Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextjs _error page missing in typescript #5203

Closed
chrillep opened this issue Jun 23, 2022 · 2 comments
Closed

nextjs _error page missing in typescript #5203

chrillep opened this issue Jun 23, 2022 · 2 comments
Labels
Team: Web Frontend SDKs team-web-sdk-frontend

Comments

@chrillep
Copy link

chrillep commented Jun 23, 2022

Core or SDK?

Platform/SDK

Which part? Which one?

javascript/nextjs

Description

https://docs.sentry.io/platforms/javascript/guides/nextjs/manual-setup/ is missing code snippets in typescript for error page

Suggested Solution

https://gist.github.com/Froelund/4d04d94931fa81a245a7dba8fc90e68a

https://github.com/sentry-demos/nextjs-typescript doesn't seem up to par

@getsentry-release
Copy link
Contributor

Routing to @getsentry/team-web-sdk-frontend for triage. ⏲️

@vladanpaunovic
Copy link
Contributor

@chrillep, thanks for the suggestion!

We greatly simplified how we are instrumenting the _error page in getsentry/sentry-javascript#5259 therefore, the typescript version of this won't be necessary as it will be very close to same as in JS.

In the following days, we will update the official example app to reflect this
change.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Team: Web Frontend SDKs team-web-sdk-frontend
Projects
None yet
Development

No branches or pull requests

4 participants