Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Policy Reporting - Content-Security-Policy has incorrect report-to info #9199

Closed
dan-goswag opened this issue Feb 22, 2024 · 9 comments · Fixed by #9440
Closed

Security Policy Reporting - Content-Security-Policy has incorrect report-to info #9199

dan-goswag opened this issue Feb 22, 2024 · 9 comments · Fixed by #9440
Assignees

Comments

@dan-goswag
Copy link

Core or SDK?

Platform/SDK

Which part? Which one?

Web - Security Headers

Description

Following the instructions at https://docs.sentry.io/product/security-policy-reporting/#content-security-policy I configured the report-to field in my CSP to send to Sentry.

However this did not work - as per getsentry/sentry#52794 report-to does not support the use of querystring parameters which are used in the examples. Report-uri continues to work as expected.

Suggested Solution

The documentation should not show using the report-to field in a way which does not currently work, so this documentation should be removed or updated.

@getsantry
Copy link
Contributor

getsantry bot commented Feb 22, 2024

Assigning to @getsentry/support for routing ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Mar 1, 2024

Routing to @getsentry/product-owners-docs for triage ⏲️

@getsantry getsantry bot moved this from Waiting for: Support to Waiting for: Product Owner in GitHub Issues with 👀 2 Mar 1, 2024
@vivianyentran
Copy link
Contributor

@rodolfoBee Can you advise us on how best to address this in the docs? Would updating the code sample to remove query parameters (e.g. sentry_key=examplePublicKey) work or is that required? If there's no easy fix, should we remove the content security policy section entirely since report-uri is deprecate and report-to doesn't work? Are there any other updates we need to make?

@rodolfoBee
Copy link
Member

@vivianyentran this is a question for the engineering team responsible for the feature.

@vivianyentran
Copy link
Contributor

@olksdr @jan-auer Can either of you help us with this?

@olksdr
Copy link
Contributor

olksdr commented Mar 13, 2024

Hi @vivianyentran,
it's on my todo list, will update the issue once I know more.

@olksdr
Copy link
Contributor

olksdr commented Mar 13, 2024

proposed some doc changes in #9440

@dan-goswag could you, please, check if the config from the above PR works for you?

@olksdr
Copy link
Contributor

olksdr commented Mar 14, 2024

The docs will be updated in the linked PR and the followup work will be done in getsentry/sentry#38940 and getsentry/relay#2645

@dan-goswag
Copy link
Author

proposed some doc changes in #9440

@dan-goswag could you, please, check if the config from the above PR works for you?

@olksdr Gave it a try, seems to work for me. Many thanks for the fix.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants