Skip to content

Commit 934ee4e

Browse files
fix: upload linked PDBs for iOS (#4527)
Co-authored-by: James Crosswell <jamescrosswell@users.noreply.github.com>
1 parent 4581417 commit 934ee4e

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
### Fixes
66

7+
- Upload linked PDBs to fix non-IL-stripped symbolication for iOS ([#4527](https://github.com/getsentry/sentry-dotnet/pull/4527))
78
- In MAUI Android apps, generate and inject UUID to APK and upload ProGuard mapping to Sentry with the UUID ([#4532](https://github.com/getsentry/sentry-dotnet/pull/4532))
89

910
## 5.15.1

integration-test/cli.Tests.ps1

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,13 @@ Describe 'MAUI' -ForEach @(
176176
'libxamarin-dotnet.dylib',
177177
'maui-app',
178178
'maui-app.pdb',
179+
'Microsoft.iOS.pdb',
180+
'Microsoft.Maui.Controls.Compatibility.pdb',
181+
'Microsoft.Maui.Controls.pdb',
182+
'Microsoft.Maui.Controls.Xaml.pdb',
183+
'Microsoft.Maui.Essentials.pdb',
184+
'Microsoft.Maui.Graphics.pdb',
185+
'Microsoft.Maui.pdb',
179186
'Sentry'
180187
)
181188
$nonZeroNumberRegex = '[1-9][0-9]*';

src/Sentry/buildTransitive/Sentry.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@
221221

222222
<PropertyGroup>
223223
<SentryCLIUploadItems>$(SentryCLIUploadDirectory)</SentryCLIUploadItems>
224-
<SentryCLIUploadItems Condition="Exists('$(IntermediateOutputPath)linked/$(AssemblyName).pdb')">$(SentryCLIUploadItems) $(IntermediateOutputPath)linked/$(AssemblyName).pdb</SentryCLIUploadItems>
224+
<SentryCLIUploadItems Condition="Exists('$(IntermediateOutputPath)linked')">$(SentryCLIUploadItems) $(IntermediateOutputPath)linked/*.pdb</SentryCLIUploadItems>
225225
<SentryCLIUploadItems Condition="'@(AndroidNativeSymbolFilesExceptDll)' != ''">$(SentryCLIUploadItems) @(AndroidNativeSymbolFilesExceptDll -> '%(Identity)', ' ')</SentryCLIUploadItems>
226226
</PropertyGroup>
227227

0 commit comments

Comments
 (0)