ScopeExtensions.Populate is now internal (#4611)

Author: jamescrosswell

CHANGELOG.md

@@ -6,6 +6,7 @@
 
 - SentryOptions.IsEnvironmentUser now defaults to false on MAUI. The means the User.Name will no longer be set, by default, to the name of the device ([#4606](https://github.com/getsentry/sentry-dotnet/pull/4606))
 - Remove unnecessary files from SentryCocoaFramework before packing ([#4602](https://github.com/getsentry/sentry-dotnet/pull/4602))
+- ScopeExtensions.Populate is now internal ([#4611](https://github.com/getsentry/sentry-dotnet/pull/4611))
 
 ### Fixes
 

src/Sentry.AspNetCore/ScopeExtensions.cs

@@ -13,7 +13,7 @@ namespace Sentry.AspNetCore;
 /// Scope Extensions
 /// </summary>
 [EditorBrowsable(EditorBrowsableState.Never)]
-public static class ScopeExtensions
+internal static class ScopeExtensions
 {
     /// <summary>
     /// Populates the scope with the HTTP data
@@ -22,7 +22,7 @@ public static class ScopeExtensions
     /// NOTE: The scope is applied to the event BEFORE running the event processors/exception processors.
     /// The main Sentry SDK has processors which run right before any additional processors to the Event
     /// </remarks>
-    public static void Populate(this Scope scope, HttpContext context, SentryAspNetCoreOptions options)
+    internal static void Populate(this Scope scope, HttpContext context, SentryAspNetCoreOptions options)
     {
         // Not to throw on code that ignores nullability warnings.
         if (scope.IsNull() || context.IsNull() || options.IsNull())
@@ -190,7 +190,7 @@ private static void SetBody(Scope scope, HttpContext context, SentryAspNetCoreOp
     /// </summary>
     /// <param name="scope">The scope.</param>
     /// <param name="activity">The activity.</param>
-    public static void Populate(this Scope scope, Activity activity)
+    internal static void Populate(this Scope scope, Activity activity)
     {
         // Not to throw on code that ignores nullability warnings.
         if (scope.IsNull() || activity.IsNull())

test/Sentry.AspNetCore.Tests/ApiApprovalTests.Run.DotNet10_0.verified.txt

@@ -39,11 +39,6 @@ namespace Sentry.AspNetCore
         public static string? TryGetHttpPath(this Sentry.TransactionSamplingContext samplingContext) { }
         public static string? TryGetHttpRoute(this Sentry.TransactionSamplingContext samplingContext) { }
     }
-    public static class ScopeExtensions
-    {
-        public static void Populate(this Sentry.Scope scope, System.Diagnostics.Activity activity) { }
-        public static void Populate(this Sentry.Scope scope, Microsoft.AspNetCore.Http.HttpContext context, Sentry.AspNetCore.SentryAspNetCoreOptions options) { }
-    }
     [Microsoft.Extensions.Logging.ProviderAlias("Sentry")]
     public class SentryAspNetCoreLoggerProvider : Sentry.Extensions.Logging.SentryLoggerProvider
     {

test/Sentry.AspNetCore.Tests/ApiApprovalTests.Run.DotNet8_0.verified.txt

@@ -39,11 +39,6 @@ namespace Sentry.AspNetCore
         public static string? TryGetHttpPath(this Sentry.TransactionSamplingContext samplingContext) { }
         public static string? TryGetHttpRoute(this Sentry.TransactionSamplingContext samplingContext) { }
     }
-    public static class ScopeExtensions
-    {
-        public static void Populate(this Sentry.Scope scope, System.Diagnostics.Activity activity) { }
-        public static void Populate(this Sentry.Scope scope, Microsoft.AspNetCore.Http.HttpContext context, Sentry.AspNetCore.SentryAspNetCoreOptions options) { }
-    }
     [Microsoft.Extensions.Logging.ProviderAlias("Sentry")]
     public class SentryAspNetCoreLoggerProvider : Sentry.Extensions.Logging.SentryLoggerProvider
     {

test/Sentry.AspNetCore.Tests/ApiApprovalTests.Run.DotNet9_0.verified.txt

@@ -39,11 +39,6 @@ namespace Sentry.AspNetCore
         public static string? TryGetHttpPath(this Sentry.TransactionSamplingContext samplingContext) { }
         public static string? TryGetHttpRoute(this Sentry.TransactionSamplingContext samplingContext) { }
     }
-    public static class ScopeExtensions
-    {
-        public static void Populate(this Sentry.Scope scope, System.Diagnostics.Activity activity) { }
-        public static void Populate(this Sentry.Scope scope, Microsoft.AspNetCore.Http.HttpContext context, Sentry.AspNetCore.SentryAspNetCoreOptions options) { }
-    }
     [Microsoft.Extensions.Logging.ProviderAlias("Sentry")]
     public class SentryAspNetCoreLoggerProvider : Sentry.Extensions.Logging.SentryLoggerProvider
     {