Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark TransactionTracer constructors as internal #2667

Closed
jamescrosswell opened this issue Sep 26, 2023 · 0 comments · Fixed by #2694
Closed

Mark TransactionTracer constructors as internal #2667

jamescrosswell opened this issue Sep 26, 2023 · 0 comments · Fixed by #2694
Milestone

Comments

@jamescrosswell
Copy link
Collaborator

// TODO: mark as internal in version 4
/// <summary>
/// Initializes an instance of <see cref="Transaction"/>.
/// </summary>
public TransactionTracer(IHub hub, string name, string operation)
: this(hub, name, operation, TransactionNameSource.Custom)
{
}
// TODO: mark as internal in version 4
/// <summary>
/// Initializes an instance of <see cref="Transaction"/>.
/// </summary>
public TransactionTracer(IHub hub, string name, string operation, TransactionNameSource nameSource)
{
_hub = hub;
_options = _hub.GetSentryOptions();
Name = name;
NameSource = nameSource;
SpanId = SpanId.Create();
TraceId = SentryId.Create();
Operation = operation;
StartTimestamp = _stopwatch.StartDateTimeOffset;
}

@jamescrosswell jamescrosswell added this to the 4.0.0 milestone Sep 26, 2023
@jamescrosswell jamescrosswell linked a pull request Oct 4, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant