Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in README #502

Closed
aselder opened this issue Apr 25, 2022 · 1 comment · Fixed by #558
Closed

Error in README #502

aselder opened this issue Apr 25, 2022 · 1 comment · Fixed by #558

Comments

@aselder
Copy link
Contributor

aselder commented Apr 25, 2022

It looks like there is an error in the documenation about config values.

The documentation mentions :root_source_code_paths, but it looks like the code is expecting :root_source_code_path

Steps to Reproduce

  1. Copy the config block from README.md
  2. Recompile the app (including Sentry)

Expected Result

Application compiles

Actual Result

❯ mix deps.compile sentry --force
==> sentry
Compiling 15 files (.ex)

== Compilation error in file lib/sentry/event.ex ==
** (ArgumentError) :root_source_code_path must be configured
    lib/sentry/config.ex:86: Sentry.Config.root_source_code_path/0
    lib/sentry/sources.ex:67: Sentry.Sources.load_files/0
    lib/sentry/event.ex:64: (module)
could not compile dependency :sentry, "mix compile" failed. Errors may have been logged above. You can recompile this dependency with "mix deps.compile sentry", update it with "mix deps.update sentry" or clean it with "mix deps.clean sentry"
@elliotblackburn
Copy link

elliotblackburn commented May 11, 2023

It looks like this is the offending function:

def root_source_code_path do
it is called by the new root_source_code_paths function for backwards compatibility but that causes the error to be issued.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants