Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dependency update while updating sentry SDK version #437

Closed
epikjjh opened this issue May 10, 2022 · 5 comments
Closed

Comments

@epikjjh
Copy link

epikjjh commented May 10, 2022

Summary

Current sentry-go has a dependency with gin, so when we are going to update the sentry-go version, it requires an update of the proper gin version too.

However, by searching this repository, gin is only used for creating test & example codes.

Motivation

When I update sentry SDK version from v0.11.0 to v0.13.0, I found out it requires an update for gin too.
However, updating gin version seems unnecessary to us since this is actually not used in sentry.
It seems to be a burden for users to consider unnecessary dependency updates.

Could you please consider this case? 🙏

Additional Context

@ghouscht
Copy link

ghouscht commented Jun 16, 2022

This is true for all the "web-framework" (or logger) dependencies. They should be removed from the main sentry-go library in my opinion. sentry-go is a library package and should have minimum dependencies. I use none of the sentry-go imported web frameworks so I don't want to have a dependency on them, but I'm forced to. 😞

Some related issues which underline that it might was a bad decision by sentry to import all kinds of things into the main sentry-go package:

It would be way better to provide separate packages containing the integrations for web-frameworks or loggers. This gives (paying) users of Sentry the freedom to choose what they are depending on in their codebase!

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@ghouscht
Copy link

ghouscht commented Dec 7, 2022

Unfortunately this is still a problem but this issue didn't get attention so far...

@cleptric
Copy link
Member

cleptric commented Dec 7, 2022

Let's track this in #156
We are very well aware of this, so it will be improved in the future!

@cleptric cleptric closed this as completed Dec 7, 2022
@dolmen
Copy link

dolmen commented Apr 13, 2023

@cleptric #156 exists for 3 years now and nothing is being done about it. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants