-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flush to receive go context type #746
Labels
Comments
This is definitely more in the spirit of Go, but we also need to respect the unified API for consistency across the various language SDKs. Perhaps we could add a more Go specific |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Currently
Flush
function receives a timeout, so when it is called someone needs to provide a timeout value. By using a context of the app and propagating toFlush
the operation will timeout whenever the context expires, so no explicit timeout is needed.Motivation
This solution will remove some corner-case in the blocking operations of an application. If a long timeout is specified the application might wait for long. If the application already performs some finalisation and has an overall shutdown timeout, we would need to calculate the duration left to timeout, in order to provide to
Flush
.Additional Context
The text was updated successfully, but these errors were encountered: