Skip to content

Commit 5b39391

Browse files
authored
Fix tags missing for compose view hierarchies (#4275)
* Fix tags missing for compose view hierarchies * Update Changelog * Extract Jetpack Compose Tag extraction into a single method * Cache internal fields * Transfer Compose Helper to Compose library, Kotlin-ify * Improve bounds calculation for ViewHierarchy and Gesture Target location * Fix formatting * Fix tests * Minor cleanup * Fix lint + Kotlin compiler warnings
1 parent 087248f commit 5b39391

File tree

23 files changed

+651
-576
lines changed

23 files changed

+651
-576
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
- The `MANIFEST.MF` of `sentry-opentelemetry-agent` now has `Implementation-Version` set to the raw version ([#4291](https://github.com/getsentry/sentry-java/pull/4291))
2828
- An example value would be `8.6.0`
2929
- The value of the `Sentry-Version-Name` attribute looks like `sentry-8.5.0-otel-2.10.0`
30+
- Fix tags missing for compose view hierarchies ([#4275](https://github.com/getsentry/sentry-java/pull/4275))
3031

3132
### Internal
3233

build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ subprojects {
155155
}
156156
}
157157

158-
if (!this.name.contains("sample") && !this.name.contains("integration-tests") && this.name != "sentry-system-test-support" && this.name != "sentry-test-support" && this.name != "sentry-compose-helper") {
158+
if (!this.name.contains("sample") && !this.name.contains("integration-tests") && this.name != "sentry-system-test-support" && this.name != "sentry-test-support") {
159159
apply<DistributionPlugin>()
160160
apply<com.vanniktech.maven.publish.MavenPublishPlugin>()
161161

sentry-android-core/build.gradle.kts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,6 @@ dependencies {
8181
compileOnly(projects.sentryAndroidTimber)
8282
compileOnly(projects.sentryAndroidReplay)
8383
compileOnly(projects.sentryCompose)
84-
compileOnly(projects.sentryComposeHelper)
8584

8685
// lifecycle processor, session tracking
8786
implementation(Config.Libs.lifecycleProcess)
@@ -109,7 +108,7 @@ dependencies {
109108
testImplementation(projects.sentryAndroidFragment)
110109
testImplementation(projects.sentryAndroidTimber)
111110
testImplementation(projects.sentryAndroidReplay)
112-
testImplementation(projects.sentryComposeHelper)
111+
testImplementation(projects.sentryCompose)
113112
testImplementation(projects.sentryAndroidNdk)
114113
testRuntimeOnly(Config.Libs.composeUi)
115114
testRuntimeOnly(Config.Libs.timber)

sentry-android-integration-tests/sentry-uitest-android/build.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ dependencies {
9797
if (applySentryIntegrations) {
9898
implementation(projects.sentryAndroid)
9999
implementation(projects.sentryCompose)
100-
implementation(projects.sentryComposeHelper)
101100
} else {
102101
implementation(projects.sentryAndroidCore)
103102
}

sentry-bom/build.gradle.kts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@ dependencies {
99
.filter {
1010
!it.name.startsWith("sentry-samples") &&
1111
it.name != project.name &&
12-
!it.name.contains("test", ignoreCase = true) &&
13-
it.name != "sentry-compose-helper"
12+
!it.name.contains("test", ignoreCase = true)
1413
}
1514
.forEach { project ->
1615
evaluationDependsOn(project.path)

sentry-compose-helper/README.md

Lines changed: 0 additions & 10 deletions
This file was deleted.

sentry-compose-helper/api/sentry-compose-helper.api

Lines changed: 0 additions & 22 deletions
This file was deleted.

sentry-compose-helper/build.gradle.kts

Lines changed: 0 additions & 67 deletions
This file was deleted.

sentry-compose-helper/src/jvmMain/java/io/sentry/compose/SentryComposeHelper.java

Lines changed: 0 additions & 41 deletions
This file was deleted.

sentry-compose-helper/src/jvmMain/java/io/sentry/compose/gestures/ComposeGestureTargetLocator.java

Lines changed: 0 additions & 162 deletions
This file was deleted.

0 commit comments

Comments
 (0)