Implement handleException method in SentryGenericDataFetcherExceptionHandler

[jrogers]

Integration

sentry

Java Version

17

Version

6.3.2

Steps to Reproduce

With graphql-java 21.2 (which is version now used in DGS 8), the deprecated method onException was removed from the DataFetcherExceptionHandler interface. In order to be compatible, my suggestion is that sentry-graphql implements the handleException method in SentryGenericDataFetcherExceptionHandler as well as onException to be compatible.

Expected Result

Exception handler works as intended with latest graphql-java

Actual Result

Execution java.lang.AbstractMethodError: Receiver class io.sentry.graphql.SentryGenericDataFetcherExceptionHandler does not define or inherit an implementation of the resolved method 'abstract java.util.concurrent.CompletableFuture handleException(graphql.execution.DataFetcherExceptionHandlerParameters)' of interface graphql.execution.DataFetcherExceptionHandler.

[jrogers]

The specific code - https://github.com/getsentry/sentry-java/blob/main/sentry-graphql/src/main/java/io/sentry/graphql/SentryGenericDataFetcherExceptionHandler.java

[adinauer]

Thanks for opening this issue @jrogers we'll improve compatibility - can't give an ETA at this point.
As a workaround, can you copy the code in SentryGenericDataFetcherExceptionHandler into a new class where you implement the now required method, so you're not blocked? Then register that as a @Bean.

[adinauer]

Sorry the deleted messages were intended for another issue.

[jrogers]

Thanks for opening this issue @jrogers we'll improve compatibility - can't give an ETA at this point. As a workaround, can you copy the code in SentryGenericDataFetcherExceptionHandler into a new class where you implement the now required method, so you're not blocked? Then register that as a @Bean.

This actually won't work if you use a delegate exeception handler, because the onException was removed from the interface entirely and SentryGraphqlExceptionHandler will fail when it calls onException on the delegate with NoSuchMethodError

[jrogers]

I just ended up forking both SentryGenericDataFetcherExceptionHandler and SentryGraphqlExceptionHandler for now...