Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add span descriptions for OkHttp child spans #3262

Closed
kahest opened this issue Mar 11, 2024 · 5 comments · Fixed by #3320
Closed

Add span descriptions for OkHttp child spans #3262

kahest opened this issue Mar 11, 2024 · 5 comments · Fixed by #3320

Comments

@kahest
Copy link
Member

kahest commented Mar 11, 2024

Description

Currently, the parent span http.client has a description and therefore the span summary shows stats grouped by description (e.g. separate for specific endpoints).

OTOH, the child spans (e.g. http.client.connection and below) are all mashed into one (unnamed span) group because they don't have a description set. Therefore you can’t see stats separated by endpoint.

For the span summary module we should add duplicate the description for the child spans. This will likely also be relevant/required for a more span oriented world and Performance v2.

@romtsn
Copy link
Member

romtsn commented Mar 11, 2024

@kahest I'm gonna move this to sentry-java as the instrumentation itself lives there

@romtsn romtsn transferred this issue from getsentry/sentry-android-gradle-plugin Mar 11, 2024
@stefanosiano stefanosiano moved this from Needs Discussion to Todo in Mobile & Cross Platform SDK Mar 13, 2024
@stefanosiano stefanosiano self-assigned this Mar 13, 2024
@Lisio
Copy link

Lisio commented Mar 17, 2024

Same story with sentry-php. Setting description for the span solves it and shows that description under "name" column.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 2 Mar 17, 2024
@kahest
Copy link
Member Author

kahest commented Mar 18, 2024

Same story with sentry-php. Setting description for the span solves it and shows that description under "name" column.

Can you clarify which spans are affected?

cc @cleptric

@Lisio
Copy link

Lisio commented Mar 18, 2024

Direct children of transaction. If I don't call setDescription for them, they'll be shown as (unnamed span). It's not very obvious that description = name.

image

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 2 Mar 18, 2024
@kahest
Copy link
Member Author

kahest commented Mar 20, 2024

@Lisio so you're creating custom spans - that's a different topic, but we'll take a note that the docs on custom instrumentation could be improved by explaining the reasons for setting a span description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants