-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add span descriptions for OkHttp child spans #3262
Comments
@kahest I'm gonna move this to sentry-java as the instrumentation itself lives there |
Same story with sentry-php. Setting description for the span solves it and shows that description under "name" column. |
Can you clarify which spans are affected? cc @cleptric |
@Lisio so you're creating custom spans - that's a different topic, but we'll take a note that the docs on custom instrumentation could be improved by explaining the reasons for setting a span description. |
Description
Currently, the parent span
http.client
has a description and therefore the span summary shows stats grouped by description (e.g. separate for specific endpoints).OTOH, the child spans (e.g.
http.client.connection
and below) are all mashed into one(unnamed span)
group because they don't have a description set. Therefore you can’t see stats separated by endpoint.For the span summary module we should add duplicate the description for the child spans. This will likely also be relevant/required for a more span oriented world and Performance v2.
The text was updated successfully, but these errors were encountered: