make async

Author: timfish

test/e2e.test.mjs

@@ -1,4 +1,4 @@
-import { spawnSync } from 'node:child_process';
+import { spawn } from 'node:child_process';
 import { join } from 'node:path';
 import { describe, expect, test } from 'vitest';
 
@@ -9,38 +9,62 @@ const NODE_MAJOR_VERSION = parseInt(process.versions.node.split('.')[0], 10);
 // macOS emulated x64 in CI is very slow!
 const timeout = process.env.CI && process.platform === 'darwin' ? 60000 : 20000;
 
-function runTest(...paths) {
+async function runTest(...paths) {
   console.time('Test Run');
   const file = join(...paths);
   const args = NODE_MAJOR_VERSION === 22 ? ['--experimental-async-context-frame', file] : [file];
-  const result = spawnSync('node', args);
-  const stdout = result.stdout?.toString().split('\n').filter(line => line.trim() !== '');
-  const stderr = result.stderr?.toString().split('\n').filter(line => line.trim() !== '');
-
-  let trace;
-  for (const line of stdout) {
-    try {
-      trace = JSON.parse(line);
-      break;
-    } catch (_) {
-      //
-    }
-  }
-
-  console.timeEnd('Test Run');
-  if (stdout.length > 0) {
-    console.log('stdout:', stdout);
-  }
-  if (stderr.length > 0) {
-    console.log('stderr:', stderr);
-  }
 
-  return { status: result.status, stdout, trace };
+  return new Promise((resolve, reject) => {
+    const child = spawn('node', args, { stdio: ['ignore', 'pipe', 'pipe'] });
+
+    let stdoutBuf = '';
+    let stderrBuf = '';
+
+    child.stdout?.on('data', chunk => {
+      stdoutBuf += chunk.toString();
+    });
+    child.stderr?.on('data', chunk => {
+      stderrBuf += chunk.toString();
+    });
+
+    child.on('error', err => reject(err));
+
+    child.on('close', code => {
+      const stdout = stdoutBuf
+        .split('\n')
+        .map(line => line.trim())
+        .filter(line => line !== '');
+      const stderr = stderrBuf
+        .split('\n')
+        .map(line => line.trim())
+        .filter(line => line !== '');
+
+      let trace;
+      for (const line of stdout) {
+        try {
+          trace = JSON.parse(line);
+          break;
+        } catch (_) {
+          // ignore non-JSON lines
+        }
+      }
+
+      console.timeEnd('Test Run');
+      if (stdout.length > 0) {
+        console.log('stdout:', stdout);
+      }
+      if (stderr.length > 0) {
+        console.log('stderr:', stderr);
+      }
+
+      resolve({ status: code, stdout, trace });
+    });
+  });
 }
 
 describe('e2e Tests', { timeout }, () => {
-  test('Capture stack trace from multiple threads', () => {
-    const result = runTest(__dirname, 'stack-traces.js')
+  test('Capture stack trace from multiple threads', async () => {
+    const result = await runTest(__dirname, 'stack-traces.js')
 
     expect(result.status).toEqual(0);
 
@@ -92,8 +116,8 @@ describe('e2e Tests', { timeout }, () => {
     }));
   });
 
-  test('detect stalled thread', () => {
-    const result = runTest(__dirname, 'stalled.js');
+  test('detect stalled thread', async () => {
+    const result = await runTest(__dirname, 'stalled.js');
 
     expect(result.status).toEqual(0);
 
@@ -127,13 +151,13 @@ describe('e2e Tests', { timeout }, () => {
     }));
   });
 
-  test('async storage state', (ctx) => {
+  test('async storage state', async (ctx) => {
     if (NODE_MAJOR_VERSION < 22) {
       ctx.skip();
       return;
     }
 
-    const result = runTest(__dirname, 'async-storage.mjs');
+    const result = await runTest(__dirname, 'async-storage.mjs');
 
     expect(result.status).toEqual(0);
 
@@ -164,8 +188,8 @@ describe('e2e Tests', { timeout }, () => {
     }));
   });
 
-  test('can be disabled', () => {
-    const result = runTest(__dirname, 'stalled-disabled.js');
+  test('can be disabled', async () => {
+    const result = await runTest(__dirname, 'stalled-disabled.js');
 
     expect(result.status).toEqual(0);
     expect(result.stdout).toContain('complete');